mirror of
https://github.com/n8n-io/n8n.git
synced 2024-12-24 20:24:05 -08:00
fix(Google Tasks Node): Fix "Show Completed" option and hide title field where not needed (#2741)
* 🐛 Google Tasks: Fix showCompleted * ⚡ Improvements Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
This commit is contained in:
parent
97ed5f8c1e
commit
9d703e366b
|
@ -171,7 +171,7 @@ export class GoogleTasks implements INodeType {
|
|||
//https://developers.google.com/tasks/v1/reference/tasks/list
|
||||
const returnAll = this.getNodeParameter('returnAll', i) as boolean;
|
||||
const taskListId = this.getNodeParameter('task', i) as string;
|
||||
const options = this.getNodeParameter(
|
||||
const { showCompleted = true, showDeleted = false, showHidden = false, ...options } = this.getNodeParameter(
|
||||
'additionalFields',
|
||||
i,
|
||||
) as IDataObject;
|
||||
|
@ -187,15 +187,11 @@ export class GoogleTasks implements INodeType {
|
|||
if (options.dueMax) {
|
||||
qs.dueMax = options.dueMax as string;
|
||||
}
|
||||
if (options.showCompleted) {
|
||||
qs.showCompleted = options.showCompleted as boolean;
|
||||
}
|
||||
if (options.showDeleted) {
|
||||
qs.showDeleted = options.showDeleted as boolean;
|
||||
}
|
||||
if (options.showHidden) {
|
||||
qs.showHidden = options.showHidden as boolean;
|
||||
}
|
||||
|
||||
qs.showCompleted = showCompleted;
|
||||
qs.showDeleted = showDeleted;
|
||||
qs.showHidden = showHidden;
|
||||
|
||||
if (options.updatedMin) {
|
||||
qs.updatedMin = options.updatedMin as string;
|
||||
}
|
||||
|
|
|
@ -76,6 +76,16 @@ export const taskFields: INodeProperties[] = [
|
|||
type: 'string',
|
||||
default: '',
|
||||
description: 'Title of the task.',
|
||||
displayOptions: {
|
||||
show: {
|
||||
operation: [
|
||||
'create',
|
||||
],
|
||||
resource: [
|
||||
'task',
|
||||
],
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
displayName: 'Additional Fields',
|
||||
|
@ -350,21 +360,21 @@ export const taskFields: INodeProperties[] = [
|
|||
name: 'showCompleted',
|
||||
type: 'boolean',
|
||||
default: true,
|
||||
description: 'Flag indicating whether completed tasks are returned in the result',
|
||||
description: 'Flag indicating whether completed tasks are returned in the result. <strong>Show Hidden</strong> must also be True to show tasks completed in first party clients such as the web UI or Google\'s mobile apps.',
|
||||
},
|
||||
{
|
||||
displayName: 'Show Deleted',
|
||||
name: 'showDeleted',
|
||||
type: 'boolean',
|
||||
default: false,
|
||||
description: 'Flag indicating whether deleted tasks are returned in the result',
|
||||
description: 'Flag indicating whether deleted tasks are returned in the result.',
|
||||
},
|
||||
{
|
||||
displayName: 'Show Hidden',
|
||||
name: 'showHidden',
|
||||
type: 'boolean',
|
||||
default: false,
|
||||
description: 'Flag indicating whether hidden tasks are returned in the result',
|
||||
description: 'Flag indicating whether hidden tasks are returned in the result.',
|
||||
},
|
||||
{
|
||||
displayName: 'Updated Min',
|
||||
|
|
Loading…
Reference in a new issue