mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Reduce memory usage in credentials risk auditing (#7663)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-11-09 14:39:16 +01:00 committed by GitHub
parent 5edf722209
commit 9fd6319583
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
packages/cli/src/audit/risks/credentials.risk.ts
View file

@ -1,13 +1,16 @@
import type { FindOperator } from 'typeorm';
import { MoreThanOrEqual } from 'typeorm';
import { In, MoreThanOrEqual } from 'typeorm';
import { DateUtils } from 'typeorm/util/DateUtils';
import { Container } from 'typedi';
import * as Db from '@/Db';
import type { IWorkflowBase } from 'n8n-workflow';
import config from '@/config';
import { CREDENTIALS_REPORT } from '@/audit/constants';
import type { WorkflowEntity } from '@db/entities/WorkflowEntity';
import type { Risk } from '@/audit/types';
import { ExecutionRepository } from '@db/repositories';
import type { WorkflowEntity } from '@db/entities/WorkflowEntity';
import {
CredentialsRepository,
ExecutionDataRepository,
ExecutionRepository,
} from '@db/repositories';
async function getAllCredsInUse(workflows: WorkflowEntity[]) {
const credsInAnyUse = new Set<string>();
@ -34,36 +37,43 @@ async function getAllCredsInUse(workflows: WorkflowEntity[]) {
}
async function getAllExistingCreds() {
const credentials = await Db.collections.Credentials.find({ select: ['id', 'name'] });
const credentials = await Container.get(CredentialsRepository).find({ select: ['id', 'name'] });
return credentials.map(({ id, name }) => ({ kind: 'credential' as const, id, name }));
}
async function getExecutionsInPastDays(days: number) {
async function getExecutedWorkflowsInPastDays(days: number): Promise<IWorkflowBase[]> {
const date = new Date();
date.setDate(date.getDate() - days);
const utcDate = DateUtils.mixedDateToUtcDatetimeString(date) as string;
return Container.get(ExecutionRepository).findMultipleExecutions(
{
const executionIds = await Container.get(ExecutionRepository)
.find({
select: ['id'],
where: {
startedAt: MoreThanOrEqual(utcDate) as unknown as FindOperator<Date>,
startedAt: MoreThanOrEqual(DateUtils.mixedDateToUtcDatetimeString(date) as Date),
},
},
{ includeData: true },
);
})
.then((executions) => executions.map(({ id }) => id));
return Container.get(ExecutionDataRepository)
.find({
select: ['workflowData'],
where: {
executionId: In(executionIds),
},
})
.then((executionData) => executionData.map(({ workflowData }) => workflowData));
}
/**
* Return IDs of credentials in workflows executed in the past n days.
*/
async function getCredsInRecentlyExecutedWorkflows(days: number) {
const recentExecutions = await getExecutionsInPastDays(days);
const executedWorkflows = await getExecutedWorkflowsInPastDays(days);
return recentExecutions.reduce<Set<string>>((acc, execution) => {
execution.workflowData?.nodes.forEach((node) => {
return executedWorkflows.reduce<Set<string>>((acc, { nodes }) => {
nodes.forEach((node) => {
if (node.credentials) {
Object.values(node.credentials).forEach((c) => {
if (c.id) acc.add(c.id);