mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(core): Allow customizing max file size in form-data payloads for webhooks (#10857)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2024-09-17 15:55:51 +02:00 committed by GitHub
parent aa00d9c2ae
commit a3335e0ecd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/@n8n/config/src/configs/endpoints.config.ts
View file

@ -65,6 +65,10 @@ export class EndpointsConfig {
@Env('N8N_PAYLOAD_SIZE_MAX') @Env('N8N_PAYLOAD_SIZE_MAX')
payloadSizeMax: number = 16; payloadSizeMax: number = 16;
/** Max payload size for files in form-data webhook payloads in MiB */
@Env('N8N_FORMDATA_FILE_SIZE_MAX')
formDataFileSizeMax: number = 200;
@Nested @Nested
metrics: PrometheusMetricsConfig; metrics: PrometheusMetricsConfig;

1
packages/@n8n/config/test/config.test.ts
View file

@ -176,6 +176,7 @@ describe('GlobalConfig', () => {
formTest: 'form-test', formTest: 'form-test',
formWaiting: 'form-waiting', formWaiting: 'form-waiting',
payloadSizeMax: 16, payloadSizeMax: 16,
formDataFileSizeMax: 200,
rest: 'rest', rest: 'rest',
webhook: 'webhook', webhook: 'webhook',
webhookTest: 'webhook-test', webhookTest: 'webhook-test',

3
packages/cli/src/webhooks/webhook-helpers.ts
View file

@ -6,6 +6,7 @@
/* eslint-disable prefer-spread */ /* eslint-disable prefer-spread */
/* eslint-disable @typescript-eslint/no-unsafe-member-access */ /* eslint-disable @typescript-eslint/no-unsafe-member-access */
/* eslint-disable @typescript-eslint/restrict-template-expressions */ /* eslint-disable @typescript-eslint/restrict-template-expressions */
import { GlobalConfig } from '@n8n/config';
import type express from 'express'; import type express from 'express';
import formidable from 'formidable'; import formidable from 'formidable';
import get from 'lodash/get'; import get from 'lodash/get';
@ -214,9 +215,11 @@ export async function executeWebhook(
if (!binaryData) { if (!binaryData) {
const { contentType, encoding } = req; const { contentType, encoding } = req;
if (contentType === 'multipart/form-data') { if (contentType === 'multipart/form-data') {
const { formDataFileSizeMax } = Container.get(GlobalConfig).endpoints;
const form = formidable({ const form = formidable({
multiples: true, multiples: true,
encoding: encoding as formidable.BufferEncoding, encoding: encoding as formidable.BufferEncoding,
maxFileSize: formDataFileSizeMax,
// TODO: pass a custom `fileWriteStreamHandler` to create binary data files directly // TODO: pass a custom `fileWriteStreamHandler` to create binary data files directly
}); });
req.body = await new Promise((resolve) => { req.body = await new Promise((resolve) => {