mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Do not attempt to save statistics data for unsaved workflows (#5106)

Browse source 
* fix: Do not attempt to save data for unsaved workflows
This commit is contained in:
Omar Ajoue 2023-01-09 12:49:27 +01:00 committed by GitHub
parent 47e32e4268
commit a43e3e4112
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/cli/src/events/WorkflowStatistics.ts
View file

@ -24,7 +24,7 @@ export async function workflowExecutionCompleted(
// Get the workflow id // Get the workflow id
const workflowId = workflowData.id; const workflowId = workflowData.id;
if (workflowId === undefined) return; if (!workflowId) return;
// Try insertion and if it fails due to key conflicts then update the existing entry instead // Try insertion and if it fails due to key conflicts then update the existing entry instead
try { try {
@ -59,7 +59,11 @@ export async function workflowExecutionCompleted(
} }
} }
export async function nodeFetchedData(workflowId: string, node: INode): Promise<void> { export async function nodeFetchedData(
workflowId: string | undefined | null,
node: INode,
): Promise<void> {
if (!workflowId) return;
// Try to insert the data loaded statistic // Try to insert the data loaded statistic
try { try {
await Db.collections.WorkflowStatistics.insert({ await Db.collections.WorkflowStatistics.insert({