mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix error paths

Browse source
This commit is contained in:
Valya Bullions 2024-10-15 17:23:31 +01:00
parent b677b9a522
commit a44ce48530
No known key found for this signature in database
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/cli/src/sso/saml/routes/saml.controller.ee.ts
View file

@ -10,6 +10,7 @@ import { AuthError } from '@/errors/response-errors/auth.error';
import { BadRequestError } from '@/errors/response-errors/bad-request.error';
import { EventService } from '@/events/event.service';
import { AuthenticatedRequest } from '@/requests';
import { sendErrorResponse } from '@/response-helper';
import { UrlService } from '@/services/url.service';
import {
@ -149,7 +150,8 @@ export class SamlController {
userEmail: loginResult.attributes.email ?? 'unknown',
authenticationMethod: 'saml',
});
throw new AuthError('SAML Authentication failed');
// Need to manually send the error response since we're using templates
return sendErrorResponse(res, new AuthError('SAML Authentication failed'));
} catch (error) {
if (isConnectionTestRequest(req)) {
return res.render('saml-connection-test-failed', { message: (error as Error).message });
@ -158,7 +160,11 @@ export class SamlController {
userEmail: 'unknown',
authenticationMethod: 'saml',
});
throw new AuthError('SAML Authentication failed: ' + (error as Error).message);
// Need to manually send the error response since we're using templates
return sendErrorResponse(
res,
new AuthError('SAML Authentication failed: ' + (error as Error).message),
);
}
}