diff --git a/packages/nodes-base/nodes/Bitly/Bitly.node.ts b/packages/nodes-base/nodes/Bitly/Bitly.node.ts index 700172ed0f..725185300a 100644 --- a/packages/nodes-base/nodes/Bitly/Bitly.node.ts +++ b/packages/nodes-base/nodes/Bitly/Bitly.node.ts @@ -131,7 +131,7 @@ export class Bitly implements INodeType { install_type: deeplink.installType, install_url: deeplink.installUrl, app_id: deeplink.appId, - }) + }); } } responseData = await bitlyApiRequest.call(this, 'POST', '/bitlinks', body); @@ -149,9 +149,6 @@ export class Bitly implements INodeType { if (updateFields.archived !== undefined) { body.archived = updateFields.archived as boolean; } - if (updateFields.domain) { - body.domain = updateFields.domain as string; - } if (updateFields.group) { body.group = updateFields.group as string; } @@ -167,7 +164,7 @@ export class Bitly implements INodeType { install_type: deeplink.installType, install_url: deeplink.installUrl, app_id: deeplink.appId, - }) + }); } } responseData = await bitlyApiRequest.call(this, 'PATCH', `/bitlinks/${linkId}`, body); diff --git a/packages/nodes-base/nodes/Bitly/GenericFunctions.ts b/packages/nodes-base/nodes/Bitly/GenericFunctions.ts index 5049b08044..1564c49497 100644 --- a/packages/nodes-base/nodes/Bitly/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Bitly/GenericFunctions.ts @@ -48,7 +48,7 @@ export async function bitlyApiRequestAllItems(this: IHookFunctions | IExecuteFun returnData.push.apply(returnData, responseData[propertyName]); if (responseData.pagination && responseData.pagination.next) { uri = responseData.pagination.next; - }; + } } while ( responseData.pagination !== undefined && responseData.pagination.next !== undefined diff --git a/packages/nodes-base/nodes/Bitly/LinkDescription.ts b/packages/nodes-base/nodes/Bitly/LinkDescription.ts index 5cd872154a..50fd5268cf 100644 --- a/packages/nodes-base/nodes/Bitly/LinkDescription.ts +++ b/packages/nodes-base/nodes/Bitly/LinkDescription.ts @@ -18,16 +18,16 @@ export const linkOperations = [ value: 'create', description: 'Create a link', }, - { - name: 'Update', - value: 'update', - description: 'Update a link', - }, { name: 'Get', value: 'get', description: 'Get a link', }, + { + name: 'Update', + value: 'update', + description: 'Update a link', + }, ], default: 'create', description: 'The operation to perform.', @@ -54,6 +54,7 @@ export const linkFields = [ }, }, default: '', + placeholder: 'https://example.com', required: true, }, { @@ -79,12 +80,6 @@ export const linkFields = [ type: 'string', default: 'bit.ly', }, - { - displayName: 'Title', - name: 'title', - type: 'string', - default: '', - }, { displayName: 'Group', name: 'group', @@ -106,6 +101,12 @@ export const linkFields = [ ] }, }, + { + displayName: 'Title', + name: 'title', + type: 'string', + default: '', + }, ], }, { @@ -132,6 +133,12 @@ export const linkFields = [ name: 'deeplinkUi', displayName: 'Deep Link', values: [ + { + displayName: 'App ID', + name: 'appId', + type: 'string', + default: '', + }, { displayName: 'App URI Path', name: 'appUriPath', @@ -150,12 +157,6 @@ export const linkFields = [ type: 'string', default: '', }, - { - displayName: 'App ID', - name: 'appId', - type: 'string', - default: '', - }, ] }, ], @@ -168,6 +169,7 @@ export const linkFields = [ name: 'id', type: 'string', default: '', + placeholder: 'bit.ly/22u3ypK', required: true, displayOptions: { show: { @@ -197,30 +199,12 @@ export const linkFields = [ }, }, options: [ - { - displayName: 'Long URL', - name: 'longUrl', - type: 'string', - default: '', - }, { displayName: 'Archived', name: 'archived', type: 'boolean', default: false, }, - { - displayName: 'Domain', - name: 'domain', - type: 'string', - default: 'bit.ly', - }, - { - displayName: 'Title', - name: 'title', - type: 'string', - default: '', - }, { displayName: 'Group', name: 'group', @@ -230,6 +214,12 @@ export const linkFields = [ loadOptionsMethod: 'getGroups', }, }, + { + displayName: 'Long URL', + name: 'longUrl', + type: 'string', + default: '', + }, { displayName: 'Tags', name: 'tags', @@ -242,6 +232,12 @@ export const linkFields = [ ] }, }, + { + displayName: 'Title', + name: 'title', + type: 'string', + default: '', + }, ], }, { @@ -268,6 +264,12 @@ export const linkFields = [ name: 'deeplinkUi', displayName: 'Deep Link', values: [ + { + displayName: 'App ID', + name: 'appId', + type: 'string', + default: '', + }, { displayName: 'App URI Path', name: 'appUriPath', @@ -286,12 +288,6 @@ export const linkFields = [ type: 'string', default: '', }, - { - displayName: 'App ID', - name: 'appId', - type: 'string', - default: '', - }, ] }, ], @@ -304,6 +300,7 @@ export const linkFields = [ name: 'id', type: 'string', default: '', + placeholder: 'bit.ly/22u3ypK', required: true, displayOptions: { show: {