mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 20:54:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡ Improve channel selection on Mattermost node

Browse source
This commit is contained in:
Jan Oberhauser 2020-11-06 13:39:38 +01:00
parent 7168b1780e
commit a6cf9bceb3
1 changed files with 30 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
packages/nodes-base/nodes/Mattermost/Mattermost.node.ts
View file

@ -1520,11 +1520,11 @@ export class Mattermost implements INodeType {
const returnData: INodePropertyOptions[] = []; const returnData: INodePropertyOptions[] = [];
let name: string; let name: string;
for (const data of responseData) { for (const data of responseData) {
if (data.delete_at !== 0) { if (data.delete_at !== 0 || (!data.display_name || !data.name)) {
continue; continue;
} }
name = `${data.name} (${data.type === 'O' ? 'public' : 'private'})`; name = `${data.team_display_name} - ${data.display_name || data.name} (${data.type === 'O' ? 'public' : 'private'})`;
returnData.push({ returnData.push({
name, name,
@ -1532,6 +1532,12 @@ export class Mattermost implements INodeType {
}); });
} }
returnData.sort((a, b) => {
if (a.name < b.name) { return -1; }
if (a.name > b.name) { return 1; }
return 0;
});
return returnData; return returnData;
}, },
@ -1548,17 +1554,18 @@ export class Mattermost implements INodeType {
const returnData: INodePropertyOptions[] = []; const returnData: INodePropertyOptions[] = [];
let name: string; let name: string;
for (const data of responseData) { for (const data of responseData) {
if (data.delete_at !== 0) { if (data.delete_at !== 0 || (!data.display_name || !data.name)) {
continue; continue;
} }
const channelTypes: IDataObject = { const channelTypes: IDataObject = {
'D': 'direct',
'G': 'group',
'O': 'public', 'O': 'public',
'P': 'private', 'P': 'private',
'D': 'direct',
}; };
name = `${data.name} (${channelTypes[data.type as string]})`; name = `${data.display_name} (${channelTypes[data.type as string]})`;
returnData.push({ returnData.push({
name, name,
@ -1566,6 +1573,12 @@ export class Mattermost implements INodeType {
}); });
} }
returnData.sort((a, b) => {
if (a.name < b.name) { return -1; }
if (a.name > b.name) { return 1; }
return 0;
});
return returnData; return returnData;
}, },
@ -1593,6 +1606,12 @@ export class Mattermost implements INodeType {
}); });
} }
returnData.sort((a, b) => {
if (a.name < b.name) { return -1; }
if (a.name > b.name) { return 1; }
return 0;
});
return returnData; return returnData;
}, },
async getUsers(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> { async getUsers(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> {
@ -1616,6 +1635,12 @@ export class Mattermost implements INodeType {
}); });
} }
returnData.sort((a, b) => {
if (a.name < b.name) { return -1; }
if (a.name > b.name) { return 1; }
return 0;
});
return returnData; return returnData;
}, },
}, },