From a732374f24354e0c1f36247f4476e743b0fc78e5 Mon Sep 17 00:00:00 2001 From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com> Date: Thu, 23 Mar 2023 11:20:11 +0100 Subject: [PATCH] fix: Update Posthog no-capture (#5693) * feat: add no-capture class for schema view * fix: add ee nocapture * fix: update no capture * fix: update ndv capturing * feat: remove no capture from empty resources list * lint: fix * test: update tests * test: add json view tests * fix: update more class to cover * lint: fix --- .../src/components/ExecutionsList.vue | 2 +- .../editor-ui/src/components/InputPanel.vue | 2 +- .../src/components/ParameterInputWrapper.vue | 1 + .../ResourceLocatorDropdown.vue | 1 + packages/editor-ui/src/components/RunData.vue | 2 - .../editor-ui/src/components/RunDataHtml.vue | 2 +- .../src/components/RunDataJson.test.ts | 107 +-- .../editor-ui/src/components/RunDataJson.vue | 5 +- .../src/components/RunDataSchemaItem.vue | 2 +- .../editor-ui/src/components/RunDataTable.vue | 9 +- .../src/components/VariableSelectorItem.vue | 4 +- .../__snapshots__/RunDataJson.test.ts.snap | 700 ++++++++++++++++++ .../__snapshots__/RunDataSchema.test.ts.snap | 12 +- .../layouts/ResourcesListLayout.vue | 2 +- 14 files changed, 789 insertions(+), 62 deletions(-) create mode 100644 packages/editor-ui/src/components/__snapshots__/RunDataJson.test.ts.snap diff --git a/packages/editor-ui/src/components/ExecutionsList.vue b/packages/editor-ui/src/components/ExecutionsList.vue index e7b6a548bf..589b5bd605 100644 --- a/packages/editor-ui/src/components/ExecutionsList.vue +++ b/packages/editor-ui/src/components/ExecutionsList.vue @@ -92,7 +92,7 @@ /> - {{ + {{ execution.workflowName || $locale.baseText('executionsList.unsavedWorkflow') }} diff --git a/packages/editor-ui/src/components/InputPanel.vue b/packages/editor-ui/src/components/InputPanel.vue index 589ccb95e6..c52d2a1e66 100644 --- a/packages/editor-ui/src/components/InputPanel.vue +++ b/packages/editor-ui/src/components/InputPanel.vue @@ -45,7 +45,7 @@ :label="`${truncate(node.name)} ${getMultipleNodesText(node.name)}`" data-test-id="ndv-input-option" > - {{ truncate(node.name) }}  + {{ truncate(node.name) }}  {{ getMultipleNodesText(node.name) }} diff --git a/packages/editor-ui/src/components/ParameterInputWrapper.vue b/packages/editor-ui/src/components/ParameterInputWrapper.vue index 441c3979cb..d1f2c73ebb 100644 --- a/packages/editor-ui/src/components/ParameterInputWrapper.vue +++ b/packages/editor-ui/src/components/ParameterInputWrapper.vue @@ -27,6 +27,7 @@ v-if="expressionOutput" :class="$style.hint" data-test-id="parameter-expression-preview" + class="ph-no-capture" :highlight="!!(expressionOutput && targetItem)" :hint="expressionOutput" :singleLine="true" diff --git a/packages/editor-ui/src/components/ResourceLocator/ResourceLocatorDropdown.vue b/packages/editor-ui/src/components/ResourceLocator/ResourceLocatorDropdown.vue index 0fff36c344..c26e8cbda8 100644 --- a/packages/editor-ui/src/components/ResourceLocator/ResourceLocatorDropdown.vue +++ b/packages/editor-ui/src/components/ResourceLocator/ResourceLocatorDropdown.vue @@ -47,6 +47,7 @@ [$style.selected]: result.value === value, [$style.hovering]: hoverIndex === i, }" + class="ph-no-capture" @click="() => onItemClick(result.value)" @mouseenter="() => onItemHover(i)" @mouseleave="() => onItemHoverLeave()" diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue index cd72958357..70666e31f1 100644 --- a/packages/editor-ui/src/components/RunData.vue +++ b/packages/editor-ui/src/components/RunData.vue @@ -290,7 +290,6 @@ -
+