mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-26 03:52:23 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(expression): prevent calls to constructor to forbid arbitrary code execution (#4139)

Browse source 
* fix(expression): prevent calls to constructor to forbid arbitrary code execution
This commit is contained in:
Omar Ajoue 2022-09-20 10:41:37 +02:00 committed by GitHub
parent 479f78b3bc
commit a8030dbda5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/workflow/src/Expression.ts
View file

@ -249,6 +249,15 @@ export class Expression {
data.Boolean = Boolean; data.Boolean = Boolean;
data.Symbol = Symbol; data.Symbol = Symbol;
const constructorValidation = new RegExp(/\.\s*constructor/gm);
if (parameterValue.match(constructorValidation)) {
throw new ExpressionError('Expression contains invalid constructor function call', {
causeDetailed: 'Constructor override attempt is not allowed due to security concerns',
runIndex,
itemIndex,
});
}
// Execute the expression // Execute the expression
const returnValue = this.renderExpression(parameterValue, data); const returnValue = this.renderExpression(parameterValue, data);
if (typeof returnValue === 'function') { if (typeof returnValue === 'function') {