mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(cli): Account for unparseable string in JSON key migration (#3927)

Browse source 
⚡ Account for unparseable string in JSON key migration
This commit is contained in:
Iván Ovejero 2022-08-23 17:13:48 +02:00 committed by GitHub
parent f22bd2805d
commit ab45898a69
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/cli/src/databases/migrations/sqlite/1659888469333-AddJsonKeyPinData.ts
View file

@ -64,8 +64,17 @@ export const addJsonKeyToPinDataColumn =
function makeUpdateParams(fetchedWorkflows: PinData.FetchedWorkflow[]) {
return fetchedWorkflows.reduce<PinData.FetchedWorkflow[]>(
(updateParams, { id, pinData: rawPinData }) => {
const pinDataPerWorkflow: PinData.Old | PinData.New =
typeof rawPinData === 'string' ? JSON.parse(rawPinData) : rawPinData;
let pinDataPerWorkflow: PinData.Old | PinData.New;
if (typeof rawPinData === 'string') {
try {
pinDataPerWorkflow = JSON.parse(rawPinData);
} catch (_) {
pinDataPerWorkflow = {};
}
} else {
pinDataPerWorkflow = rawPinData;
}
const newPinDataPerWorkflow = Object.keys(pinDataPerWorkflow).reduce<PinData.New>(
(newPinDataPerWorkflow, nodeName) => {

2
packages/cli/src/databases/utils/migrations.types.ts
View file

@ -5,7 +5,7 @@ export namespace PinData {
export type New = { [nodeName: string]: INodeExecutionData[] };
export type FetchedWorkflow = { id: number; pinData: string | object };
export type FetchedWorkflow = { id: number; pinData: string | Old };
}
export function isObjectLiteral(maybeObject: unknown): maybeObject is { [key: string]: string } {