mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-12 05:17:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Throw on adding execution without execution data (#9903)

Browse source
This commit is contained in:
Iván Ovejero 2024-07-02 15:11:30 +02:00 committed by GitHub
parent f229577209
commit abb74587db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/cli/src/databases/repositories/execution.repository.ts
View file

@ -43,6 +43,8 @@ import { ExecutionDataRepository } from './executionData.repository';
import { Logger } from '@/Logger'; import { Logger } from '@/Logger';
import type { ExecutionSummaries } from '@/executions/execution.types'; import type { ExecutionSummaries } from '@/executions/execution.types';
import { PostgresLiveRowsRetrievalError } from '@/errors/postgres-live-rows-retrieval.error'; import { PostgresLiveRowsRetrievalError } from '@/errors/postgres-live-rows-retrieval.error';
import { separate } from '@/utils';
import { ErrorReporterProxy as ErrorReporter } from 'n8n-workflow';
export interface IGetExecutionsQueryFilter { export interface IGetExecutionsQueryFilter {
id?: FindOperator<string> | string; id?: FindOperator<string> | string;
@ -156,7 +158,9 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
const executions = await this.find(queryParams); const executions = await this.find(queryParams);
if (options?.includeData && options?.unflattenData) { if (options?.includeData && options?.unflattenData) {
return executions.map((execution) => { const [valid, invalid] = separate(executions, (e) => e.executionData !== null);
this.reportInvalidExecutions(invalid);
return valid.map((execution) => {
const { executionData, metadata, ...rest } = execution; const { executionData, metadata, ...rest } = execution;
return { return {
...rest, ...rest,
@ -166,7 +170,9 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
} as IExecutionResponse; } as IExecutionResponse;
}); });
} else if (options?.includeData) { } else if (options?.includeData) {
return executions.map((execution) => { const [valid, invalid] = separate(executions, (e) => e.executionData !== null);
this.reportInvalidExecutions(invalid);
return valid.map((execution) => {
const { executionData, metadata, ...rest } = execution; const { executionData, metadata, ...rest } = execution;
return { return {
...rest, ...rest,
@ -183,6 +189,16 @@ export class ExecutionRepository extends Repository<ExecutionEntity> {
}); });
} }
reportInvalidExecutions(executions: ExecutionEntity[]) {
if (executions.length === 0) return;
ErrorReporter.error(
new ApplicationError('Found executions without executionData', {
extra: { executionIds: executions.map(({ id }) => id) },
}),
);
}
async findSingleExecution( async findSingleExecution(
id: string, id: string,
options?: { options?: {