mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-13 05:47:31 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

feat(core): Add support for $("NodeName").isExecuted (#8683)

Browse source
This commit is contained in:
Jan Oberhauser 2024-02-20 18:25:04 +01:00 committed by GitHub
parent e2f2fc910d
commit ad82f0c0c8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/workflow/src/WorkflowDataProxy.ts
View file

@ -922,10 +922,6 @@ export class WorkflowDataProxy {
throw createExpressionError(`"${nodeName}" node doesn't exist`); throw createExpressionError(`"${nodeName}" node doesn't exist`);
} }
if (!that?.runExecutionData?.resultData?.runData.hasOwnProperty(nodeName)) {
throw createExpressionError(`no data, execute "${nodeName}" node first`);
}
return new Proxy( return new Proxy(
{}, {},
{ {
@ -933,6 +929,7 @@ export class WorkflowDataProxy {
ownKeys() { ownKeys() {
return [ return [
'pairedItem', 'pairedItem',
'isExecuted',
'itemMatching', 'itemMatching',
'item', 'item',
'first', 'first',
@ -945,6 +942,12 @@ export class WorkflowDataProxy {
get(target, property, receiver) { get(target, property, receiver) {
if (property === 'isProxy') return true; if (property === 'isProxy') return true;
if (!that?.runExecutionData?.resultData?.runData.hasOwnProperty(nodeName)) {
if (property === 'isExecuted') return false;
throw createExpressionError(`no data, execute "${nodeName}" node first`);
}
if (property === 'isExecuted') return true;
if (['pairedItem', 'itemMatching', 'item'].includes(property as string)) { if (['pairedItem', 'itemMatching', 'item'].includes(property as string)) {
const pairedItemMethod = (itemIndex?: number) => { const pairedItemMethod = (itemIndex?: number) => {
if (itemIndex === undefined) { if (itemIndex === undefined) {

5
packages/workflow/test/WorkflowDataProxy.test.ts
View file

@ -294,8 +294,9 @@ describe('WorkflowDataProxy', () => {
expect(() => proxy.$('doNotExist')).toThrowError(ExpressionError); expect(() => proxy.$('doNotExist')).toThrowError(ExpressionError);
}); });
test('$("NodeName")', () => { test('test $("NodeName").isExecuted', () => {
expect(() => proxy.$('Set')).toThrowError(ExpressionError); expect(proxy.$('Function').isExecuted).toEqual(true);
expect(proxy.$('Set').isExecuted).toEqual(false);
}); });
test('test $input.all()', () => { test('test $input.all()', () => {