mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Fix some comments (no-changelog) (#11816)

Browse source 
Signed-off-by: binchengqu <bincheng@before.tech>
This commit is contained in:
Bin Chang 2024-11-22 20:31:52 +08:00 committed by GitHub
parent 05c61091db
commit adf026c201
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/services/dynamic-node-parameters.service.ts
View file

@ -54,7 +54,7 @@ export class DynamicNodeParametersService {
): Promise<INodePropertyOptions[]> { ): Promise<INodePropertyOptions[]> {
const nodeType = this.getNodeType(nodeTypeAndVersion); const nodeType = this.getNodeType(nodeTypeAndVersion);
if (!nodeType.description.requestDefaults?.baseURL) { if (!nodeType.description.requestDefaults?.baseURL) {
// This in in here for now for security reasons. // This is in here for now for security reasons.
// Background: As the full data for the request to make does get send, and the auth data // Background: As the full data for the request to make does get send, and the auth data
// will then be applied, would it be possible to retrieve that data like that. By at least // will then be applied, would it be possible to retrieve that data like that. By at least
// requiring a baseURL to be defined can at least not a random server be called. // requiring a baseURL to be defined can at least not a random server be called.

2
packages/editor-ui/src/views/NodeView.vue
View file

@ -1829,7 +1829,7 @@ export default defineComponent({
return; return;
} }
} else { } else {
// Pasted data is is possible workflow data // Pasted data is possible workflow data
try { try {
// Check first if it is valid JSON // Check first if it is valid JSON
workflowData = JSON.parse(plainTextData); workflowData = JSON.parse(plainTextData);

2
packages/workflow/src/Workflow.ts
View file

@ -435,7 +435,7 @@ export class Workflow {
) { ) {
// Is expression so has to be rewritten // Is expression so has to be rewritten
// To not run the "expensive" regex stuff when it is not needed // To not run the "expensive" regex stuff when it is not needed
// make a simple check first if it really contains the the node-name // make a simple check first if it really contains the node-name
if (parameterValue.includes(currentName)) { if (parameterValue.includes(currentName)) {
// Really contains node-name (even though we do not know yet if really as $node-expression) // Really contains node-name (even though we do not know yet if really as $node-expression)