mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(Google Sheets Node): Add upsert support (#2733)

Browse source 
* ✨ Add upsert support for Google Sheets

* ⚡ updated description

* ⚡ updated display name and description

* ⚡ Order resources alphabetically

Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
This commit is contained in:
pemontto 2022-04-23 02:15:55 +10:00 committed by GitHub
parent 83998a15b0
commit aeb5a1234a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
packages/nodes-base/nodes/Google/Sheet/GoogleSheet.ts
View file

@ -268,7 +268,16 @@ export class GoogleSheet {
* @returns {Promise<string[][]>}
* @memberof GoogleSheet
*/
async updateSheetData(inputData: IDataObject[], indexKey: string, range: string, keyRowIndex: number, dataStartRowIndex: number, valueInputMode: ValueInputOption, valueRenderMode: ValueRenderOption): Promise<string[][]> {
async updateSheetData(
inputData: IDataObject[],
indexKey: string,
range: string,
keyRowIndex: number,
dataStartRowIndex: number,
valueInputMode: ValueInputOption,
valueRenderMode: ValueRenderOption,
upsert = false,
): Promise<string[][]> {
// Get current data in Google Sheet
let rangeStart: string, rangeEnd: string, rangeFull: string;
let sheet: string | undefined = undefined;
@ -333,14 +342,20 @@ export class GoogleSheet {
itemKey = inputItem[indexKey] as string;
// if ([undefined, null].includes(inputItem[indexKey] as string | undefined | null)) {
if (itemKey === undefined || itemKey === null) {
// Item does not have the indexKey so we can ignore it
// Item does not have the indexKey so we can ignore it or append it if upsert true
if (upsert) {
const data = await this.appendSheetData([inputItem], this.encodeRange(range), keyRowIndex, valueInputMode);
}
continue;
}
// Item does have the key so check if it exists in Sheet
itemKeyIndex = keyColumnIndexLookup.indexOf(itemKey as string);
if (itemKeyIndex === -1) {
// Key does not exist in the Sheet so it can not be updated so skip it
// Key does not exist in the Sheet so it can not be updated so skip it or append it if upsert true
if (upsert) {
const data = await this.appendSheetData([inputItem], this.encodeRange(range), keyRowIndex, valueInputMode);
}
continue;
}

18
packages/nodes-base/nodes/Google/Sheet/GoogleSheets.node.ts
View file

@ -133,6 +133,11 @@ export class GoogleSheets implements INodeType {
value: 'create',
description: 'Create a new sheet',
},
{
name: 'Create or Update',
value: 'upsert',
description: 'Create a new record, or update the current one if it already exists',
},
{
name: 'Delete',
value: 'delete',
@ -363,6 +368,7 @@ export class GoogleSheets implements INodeType {
],
operation: [
'update',
'upsert',
],
},
},
@ -381,6 +387,7 @@ export class GoogleSheets implements INodeType {
],
operation: [
'update',
'upsert',
],
rawData: [
true,
@ -512,6 +519,7 @@ export class GoogleSheets implements INodeType {
],
operation: [
'update',
'upsert',
],
rawData: [
false,
@ -537,6 +545,7 @@ export class GoogleSheets implements INodeType {
'lookup',
'read',
'update',
'upsert',
],
},
},
@ -579,6 +588,7 @@ export class GoogleSheets implements INodeType {
'/operation': [
'append',
'update',
'upsert',
],
},
},
@ -637,6 +647,7 @@ export class GoogleSheets implements INodeType {
show: {
'/operation': [
'update',
'upsert',
],
'/rawData': [
false,
@ -1293,10 +1304,11 @@ export class GoogleSheets implements INodeType {
}
return [this.helpers.returnJsonArray(returnData)];
} else if (operation === 'update') {
} else if (operation === 'update' || operation === 'upsert') {
// ----------------------------------
// update
// update/upsert
// ----------------------------------
const upsert = operation === 'upsert' ? true : false;
try {
const rawData = this.getNodeParameter('rawData', 0) as boolean;
@ -1324,7 +1336,7 @@ export class GoogleSheets implements INodeType {
setData.push(item.json);
});
const data = await sheet.updateSheetData(setData, keyName, range, keyRow, dataStartRow, valueInputMode, valueRenderMode);
const data = await sheet.updateSheetData(setData, keyName, range, keyRow, dataStartRow, valueInputMode, valueRenderMode, upsert);
}
// TODO: Should add this data somewhere
// TODO: Should have something like add metadata which does not get passed through