From af703371fc96dcfdd8f418201d3880f124cfcfc4 Mon Sep 17 00:00:00 2001 From: feelgood-interface <78543720+feelgood-interface@users.noreply.github.com> Date: Thu, 16 Feb 2023 12:00:06 +0100 Subject: [PATCH] fix(HTTP Request Node): Ignore empty body for auto detect json (#5215) --- .../nodes/HttpRequest/V3/HttpRequestV3.node.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts b/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts index c2a255b43c..af4eada7bd 100644 --- a/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts +++ b/packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts @@ -1344,7 +1344,17 @@ export class HttpRequestV3 implements INodeType { const responseContentType = response.headers['content-type'] ?? ''; if (responseContentType.includes('application/json')) { responseFormat = 'json'; - response.body = jsonParse(Buffer.from(response.body).toString()); + const neverError = this.getNodeParameter( + 'options.response.response.neverError', + 0, + false, + ) as boolean; + const data = Buffer.from(response.body).toString(); + response.body = jsonParse(data, { + ...(neverError + ? { fallbackValue: {} } + : { errorMessage: 'Invalid JSON in response body' }), + }); } else if (binaryContentTypes.some((e) => responseContentType.includes(e))) { responseFormat = 'file'; } else {