mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix zero treated as missing value in resource locator (#4612)

Browse source 
* 🐛 Adding a type guard to validate resource locator parameter values
* ✔️ Fixing a linting error
Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Milorad FIlipović 2022-11-16 09:21:30 +01:00 committed by GitHub
parent 53d2526cd1
commit b0bbcf6028
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/workflow/src/NodeHelpers.ts
View file

@ -38,6 +38,7 @@ import {
NodeParameterValue,
WebhookHttpMethod,
} from './Interfaces';
import { isValidResourceLocatorParameterValue } from './type-guards';
import { deepCopy } from './utils';
import type { Workflow } from './Workflow';
@ -1150,7 +1151,7 @@ export function addToIssuesIfMissing(
(nodeProperties.type === 'dateTime' && value === undefined) ||
(nodeProperties.type === 'options' && (value === '' || value === undefined)) ||
(nodeProperties.type === 'resourceLocator' &&
(!value || (typeof value === 'object' && !value.value)))
!isValidResourceLocatorParameterValue(value as INodeParameterResourceLocator))
) {
// Parameter is required but empty
if (foundIssues.parameters === undefined) {

20
packages/workflow/src/type-guards.ts
View file

@ -1,4 +1,9 @@
import { INodeProperties, INodePropertyOptions, INodePropertyCollection } from './Interfaces';
import {
INodeProperties,
INodePropertyOptions,
INodePropertyCollection,
INodeParameterResourceLocator,
} from './Interfaces';
export const isINodeProperties = (
item: INodePropertyOptions | INodeProperties | INodePropertyCollection,
@ -25,3 +30,16 @@ export const isINodePropertyCollectionList = (
): items is INodePropertyCollection[] => {
return Array.isArray(items) && items.every(isINodePropertyCollection);
};
export const isValidResourceLocatorParameterValue = (
value: INodeParameterResourceLocator,
): boolean => {
if (typeof value === 'object') {
if (typeof value.value === 'number') {
return true; // Accept all numbers
}
return !!value.value;
} else {
return !!value;
}
};