feat(Intercom Node): Update credential to new style (#11485)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Test Master / Lint (push) Blocked by required conditions
Test Master / Notify Slack on failure (push) Blocked by required conditions

This commit is contained in:
Jon 2024-10-31 16:38:11 +00:00 committed by GitHub
parent 130c942f63
commit b137e13845
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 28 additions and 13 deletions

View file

@ -1,4 +1,9 @@
import type { ICredentialType, INodeProperties } from 'n8n-workflow'; import type {
IAuthenticateGeneric,
ICredentialTestRequest,
ICredentialType,
INodeProperties,
} from 'n8n-workflow';
export class IntercomApi implements ICredentialType { export class IntercomApi implements ICredentialType {
name = 'intercomApi'; name = 'intercomApi';
@ -16,4 +21,22 @@ export class IntercomApi implements ICredentialType {
default: '', default: '',
}, },
]; ];
authenticate: IAuthenticateGeneric = {
type: 'generic',
properties: {
headers: {
Authorization: '=Bearer {{$credentials.apiKey}}',
Accept: 'application/json',
},
},
};
test: ICredentialTestRequest = {
request: {
baseURL: 'https://api.intercom.io',
url: '/me',
method: 'GET',
},
};
} }

View file

@ -4,7 +4,7 @@ import type {
IHookFunctions, IHookFunctions,
ILoadOptionsFunctions, ILoadOptionsFunctions,
JsonObject, JsonObject,
IRequestOptions, IHttpRequestOptions,
IHttpRequestMethods, IHttpRequestMethods,
} from 'n8n-workflow'; } from 'n8n-workflow';
import { NodeApiError } from 'n8n-workflow'; import { NodeApiError } from 'n8n-workflow';
@ -18,24 +18,16 @@ export async function intercomApiRequest(
query?: IDataObject, query?: IDataObject,
uri?: string, uri?: string,
): Promise<any> { ): Promise<any> {
const credentials = await this.getCredentials('intercomApi'); const options: IHttpRequestOptions = {
const headerWithAuthentication = Object.assign(
{},
{ Authorization: `Bearer ${credentials.apiKey}`, Accept: 'application/json' },
);
const options: IRequestOptions = {
headers: headerWithAuthentication,
method, method,
qs: query, qs: query,
uri: uri || `https://api.intercom.io${endpoint}`, url: uri ?? `https://api.intercom.io${endpoint}`,
body, body,
json: true, json: true,
}; };
try { try {
return await this.helpers.request(options); return await this.helpers.httpRequestWithAuthentication.call(this, 'intercomApi', options);
} catch (error) { } catch (error) {
throw new NodeApiError(this.getNode(), error as JsonObject); throw new NodeApiError(this.getNode(), error as JsonObject);
} }