mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(editor): Show credential share info only to appropriate users (#8020)

Browse source 
## Summary
The credential owner should not see the sharing info box


![image](https://github.com/n8n-io/n8n/assets/5410822/d85b47f8-f4cf-4009-beaf-03bc62008feb)
This commit is contained in:
Csaba Tuncsik 2023-12-14 11:48:51 +01:00 committed by GitHub
parent ce1ae6a7c0
commit b29b4d442b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
cypress/e2e/17-sharing.cy.ts
View file

@ -131,7 +131,7 @@ describe('Sharing', { disableAutoLogin: true }, () => {
credentialsModal.getters.testSuccessTag().should('be.visible');
});
it.only('should work for admin role on credentials created by others (also can share it with themselves)', () => {
it('should work for admin role on credentials created by others (also can share it with themselves)', () => {
cy.signin(INSTANCE_MEMBERS[0]);
cy.visit(credentialsPage.url);
@ -150,6 +150,9 @@ describe('Sharing', { disableAutoLogin: true }, () => {
credentialsModal.getters.testSuccessTag().should('be.visible');
cy.get('input').should('not.have.length');
credentialsModal.actions.changeTab('Sharing');
cy.contains(
'You can view this credential because you have permission to read and share',
).should('be.visible');
credentialsModal.getters.usersSelect().click();
cy.getByTestId('user-email')

10
packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue
View file

@ -41,7 +41,15 @@
})
}}
</n8n-info-tip>
<n8n-info-tip v-if="credentialPermissions.read" class="mb-s" :bold="false">
<n8n-info-tip
v-if="
credentialPermissions.read &&
credentialPermissions.share &&
!credentialPermissions.isOwner
"
class="mb-s"
:bold="false"
>
<i18n-t keypath="credentialEdit.credentialSharing.info.reader">
<template v-if="!isCredentialSharedWithCurrentUser" #notShared>
{{ $locale.baseText('credentialEdit.credentialSharing.info.notShared') }}

2
packages/editor-ui/src/plugins/i18n/locales/en.json
View file

@ -420,7 +420,7 @@
"credentialEdit.oAuthButton.signInWithGoogle": "Sign in with Google",
"credentialEdit.credentialSharing.info.owner": "Sharing a credential allows people to use it in their workflows. They cannot access credential details.",
"credentialEdit.credentialSharing.info.reader": "You can view this credential because you have permission to read and share (and rename or delete it too).{notShared}",
"credentialEdit.credentialSharing.info.notShared": "To use it in a workflow, ask the credential owner to share it with you.",
"credentialEdit.credentialSharing.info.notShared": "To use it in a workflow you need to share it with yourself.",
"credentialEdit.credentialSharing.info.sharee": "Only {credentialOwnerName} can change who this credential is shared with",
"credentialEdit.credentialSharing.info.sharee.fallback": "the owner",
"credentialEdit.credentialSharing.select.placeholder": "Add users...",