mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(HTTP Request Node): Fix itemIndex in HTTP Request errors (#5991)

Browse source
This commit is contained in:
Jan Oberhauser 2023-04-18 11:48:38 +02:00 committed by GitHub
parent 9693142985
commit b351c62659
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts
View file

@ -967,7 +967,7 @@ export class HttpRequestV1 implements INodeType {
if (response!.status !== 'fulfilled') { if (response!.status !== 'fulfilled') {
if (!this.continueOnFail()) { if (!this.continueOnFail()) {
// throw error; // throw error;
throw new NodeApiError(this.getNode(), response as JsonObject); throw new NodeApiError(this.getNode(), response as JsonObject, { itemIndex });
} else { } else {
// Return the actual reason as error // Return the actual reason as error
returnItems.push({ returnItems.push({

2
packages/nodes-base/nodes/HttpRequest/V2/HttpRequestV2.node.ts
View file

@ -1019,7 +1019,7 @@ export class HttpRequestV2 implements INodeType {
if (response!.status !== 'fulfilled') { if (response!.status !== 'fulfilled') {
if (!this.continueOnFail()) { if (!this.continueOnFail()) {
// throw error; // throw error;
throw new NodeApiError(this.getNode(), response as JsonObject); throw new NodeApiError(this.getNode(), response as JsonObject, { itemIndex });
} else { } else {
// Return the actual reason as error // Return the actual reason as error
returnItems.push({ returnItems.push({

8
packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file

@ -1176,7 +1176,7 @@ export class HttpRequestV3 implements INodeType {
this.getNode(), this.getNode(),
'JSON parameter need to be an valid JSON', 'JSON parameter need to be an valid JSON',
{ {
runIndex: itemIndex, itemIndex,
}, },
); );
} }
@ -1242,7 +1242,7 @@ export class HttpRequestV3 implements INodeType {
this.getNode(), this.getNode(),
'JSON parameter need to be an valid JSON', 'JSON parameter need to be an valid JSON',
{ {
runIndex: itemIndex, itemIndex,
}, },
); );
} }
@ -1264,7 +1264,7 @@ export class HttpRequestV3 implements INodeType {
this.getNode(), this.getNode(),
'JSON parameter need to be an valid JSON', 'JSON parameter need to be an valid JSON',
{ {
runIndex: itemIndex, itemIndex,
}, },
); );
} }
@ -1381,7 +1381,7 @@ export class HttpRequestV3 implements INodeType {
if (autoDetectResponseFormat && response.reason.error instanceof Buffer) { if (autoDetectResponseFormat && response.reason.error instanceof Buffer) {
response.reason.error = Buffer.from(response.reason.error as Buffer).toString(); response.reason.error = Buffer.from(response.reason.error as Buffer).toString();
} }
throw new NodeApiError(this.getNode(), response as JsonObject); throw new NodeApiError(this.getNode(), response as JsonObject, { itemIndex });
} else { } else {
// Return the actual reason as error // Return the actual reason as error
returnItems.push({ returnItems.push({