From b4d3f12b512acf30e0b9a1b9d3fbbc7895ce0c67 Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Tue, 13 Dec 2022 10:55:31 +0200
Subject: [PATCH] feat: Update readonly node notice when using foreign
 credentials (no-changelog) (#4895)

---
 packages/editor-ui/src/components/NodeSettings.vue  | 7 ++++++-
 packages/editor-ui/src/plugins/i18n/locales/en.json | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/packages/editor-ui/src/components/NodeSettings.vue b/packages/editor-ui/src/components/NodeSettings.vue
index 87c39cf8a7..c7d526ec6e 100644
--- a/packages/editor-ui/src/components/NodeSettings.vue
+++ b/packages/editor-ui/src/components/NodeSettings.vue
@@ -73,7 +73,7 @@
 		>
 			<n8n-notice
 				v-if="hasForeignCredential"
-				:content="$locale.baseText('nodeSettings.hasForeignCredential')"
+				:content="$locale.baseText('nodeSettings.hasForeignCredential', { interpolate: { owner: workflowOwnerName } })"
 			/>
 			<div v-show="openPanel === 'params'">
 				<node-webhooks :node="node" :nodeType="nodeType" />
@@ -167,6 +167,7 @@ import { useNDVStore } from '@/stores/ndv';
 import { useNodeTypesStore } from '@/stores/nodeTypes';
 import { useHistoryStore } from '@/stores/history';
 import { RenameNodeCommand } from '@/models/history';
+import useWorkflowsEEStore from "@/stores/workflows.ee";
 
 export default mixins(externalHooks, nodeHelpers).extend({
 	name: 'NodeSettings',
@@ -186,6 +187,7 @@ export default mixins(externalHooks, nodeHelpers).extend({
 			useNDVStore,
 			useUIStore,
 			useWorkflowsStore,
+			useWorkflowsEEStore,
 		),
 		isCurlImportModalOpen(): boolean {
 			return this.uiStore.isModalOpen(IMPORT_CURL_MODAL_KEY);
@@ -258,6 +260,9 @@ export default mixins(externalHooks, nodeHelpers).extend({
 		isTriggerNode(): boolean {
 			return this.nodeTypesStore.isTriggerNode(this.node.type);
 		},
+		workflowOwnerName(): string {
+			return this.workflowsEEStore.getWorkflowOwnerName(`${this.workflowsStore.workflowId}`);
+		},
 	},
 	props: {
 		eventBus: {},
diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json
index c39d9d8bfa..74e8cfcc1b 100644
--- a/packages/editor-ui/src/plugins/i18n/locales/en.json
+++ b/packages/editor-ui/src/plugins/i18n/locales/en.json
@@ -776,7 +776,7 @@
 	"nodeSettings.useTheHttpRequestNode": "Use the <b>HTTP Request</b> node to make a custom API call. We'll take care of the {nodeTypeDisplayName} auth for you. <a target=\"_blank\" href=\"https://docs.n8n.io/integrations/custom-operations/\">Learn more</a>",
 	"nodeSettings.waitBetweenTries.description": "How long to wait between each attempt (in milliseconds)",
 	"nodeSettings.waitBetweenTries.displayName": "Wait Between Tries (ms)",
-	"nodeSettings.hasForeignCredential": "This node is working as expected, but you can't edit it since its credentials aren't shared with you. To edit this node, please ask the owner of the workflow to share the credentials with you. Alternatively, you can also duplicate this node in the workflow and add your own credentials.",
+	"nodeSettings.hasForeignCredential": "To edit this node, either:<br/>a) Ask {owner} to share the credential with you, or<br/>b) Duplicate the node and add your own credential",
 	"nodeView.addNode": "Add node",
 	"nodeView.addATriggerNodeFirst": "Add a <a data-action='showNodeCreator'>Trigger Node</a> first",
 	"nodeView.addOrEnableTriggerNode": "<a data-action='showNodeCreator'>Add</a> or enable a Trigger node to execute the workflow",