mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-24 11:02:12 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(core): Account for non-ASCII chars in filename on binary data download (#7742)

Browse source 
https://n8nio.sentry.io/issues/4641538638
This commit is contained in:
Iván Ovejero 2023-11-17 10:07:44 +01:00 committed by GitHub
parent abe36691ab
commit b4ebb1a28d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/cli/src/controllers/binaryData.controller.ts
View file

@ -41,8 +41,9 @@ export class BinaryDataController {
if (mimeType) res.setHeader('Content-Type', mimeType); if (mimeType) res.setHeader('Content-Type', mimeType);
if (action === 'download') { if (action === 'download' && fileName) {
res.setHeader('Content-Disposition', `attachment; filename="${fileName}"`); const encodedFilename = encodeURIComponent(fileName);
res.setHeader('Content-Disposition', `attachment; filename="${encodedFilename}"`);
} }
return await this.binaryDataService.getAsStream(binaryDataId); return await this.binaryDataService.getAsStream(binaryDataId);

20
packages/cli/test/integration/binaryData.api.test.ts
View file

@ -87,6 +87,26 @@ describe('GET /binary-data', () => {
}); });
}); });
describe('should handle non-ASCII filename [filesystem]', () => {
test('on request to download', async () => {
const nonAsciiFileName = 'äöüß.png';
const res = await authOwnerAgent
.get('/binary-data')
.query({
id: fsBinaryDataId,
fileName: nonAsciiFileName,
mimeType,
action: 'download',
})
.expect(200);
expect(res.headers['content-disposition']).toBe(
`attachment; filename="${encodeURIComponent(nonAsciiFileName)}"`,
);
});
});
describe('should return 404 on file not found [filesystem]', () => { describe('should return 404 on file not found [filesystem]', () => {
test.each(['view', 'download'])('on request to %s', async (action) => { test.each(['view', 'download'])('on request to %s', async (action) => {
binaryDataService.getAsStream.mockImplementation(throwFileNotFound); binaryDataService.getAsStream.mockImplementation(throwFileNotFound);