mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-09-20 23:07:32 -07:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

⚡ Improvements

Browse source
This commit is contained in:
Jan Oberhauser 2021-12-23 21:00:08 +01:00
parent 395f8ed5b5
commit b4f2251bcb
5 changed files with 6 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/telemetry/index.ts
View file

@ -186,13 +186,11 @@ export class Telemetry {
async track(eventName: string, properties?: IDataObject): Promise<void> { async track(eventName: string, properties?: IDataObject): Promise<void> {
return new Promise<void>((resolve) => { return new Promise<void>((resolve) => {
if (this.client) { if (this.client) {
// @ts-ignore
this.client.track( this.client.track(
{ {
userId: this.instanceId, userId: this.instanceId,
anonymousId: '000000000000', anonymousId: '000000000000',
event: eventName, event: eventName,
// @ts-ignore
properties, properties,
}, },
resolve, resolve,

1
packages/cli/tsconfig.json
View file

@ -11,7 +11,6 @@
"module": "commonjs", "module": "commonjs",
"noImplicitAny": true, "noImplicitAny": true,
"removeComments": true, "removeComments": true,
"skipLibCheck": true,
"strictNullChecks": true, "strictNullChecks": true,
"forceConsistentCasingInFileNames": true, "forceConsistentCasingInFileNames": true,
"noImplicitReturns": true, "noImplicitReturns": true,

12
packages/editor-ui/src/components/CodeEdit.vue
View file

@ -39,7 +39,7 @@ export default mixins(
workflowHelpers, workflowHelpers,
).extend({ ).extend({
name: 'CodeEdit', name: 'CodeEdit',
props: ['codeAutocomplete', 'dialogVisible', 'parameter', 'type', 'value'], props: ['codeAutocomplete', 'parameter', 'type', 'value'],
data() { data() {
return { return {
monacoInstance: null as monaco.editor.IStandaloneCodeEditor | null, monacoInstance: null as monaco.editor.IStandaloneCodeEditor | null,
@ -142,7 +142,7 @@ export default mixins(
const workflow = this.getWorkflow(); const workflow = this.getWorkflow();
const activeNode: INodeUi | null = this.$store.getters.activeNode; const activeNode: INodeUi | null = this.$store.getters.activeNode;
const parentNode = workflow.getParentNodes(activeNode!.name, inputName, 1); const parentNode = workflow.getParentNodes(activeNode!.name, inputName, 1);
const inputIndex = workflow.getNodeConnectionOutputIndex(activeNode.name, parentNode[0]); const inputIndex = workflow.getNodeConnectionOutputIndex(activeNode!.name, parentNode[0]) || 0;
const autocompleteData: string[] = []; const autocompleteData: string[] = [];
@ -157,8 +157,8 @@ export default mixins(
}; };
} else { } else {
runExecutionData = executionData.data; runExecutionData = executionData.data;
if (runExecutionData.resultData.runData[activeNode.name]) { if (runExecutionData.resultData.runData[activeNode!.name]) {
runIndex = runExecutionData.resultData.runData[activeNode.name].length - 1; runIndex = runExecutionData.resultData.runData[activeNode!.name].length - 1;
} }
} }
@ -240,10 +240,6 @@ export default mixins(
</script> </script>
<style scoped> <style scoped>
.editor-description {
font-weight: bold;
padding: 0 0 0.5em 0.2em;
}
.text-editor { .text-editor {
min-height: 30rem; min-height: 30rem;

2
packages/nodes-base/nodes/Function/Function.node.ts
View file

@ -127,7 +127,7 @@ return items;`,
if (this.continueOnFail()) { if (this.continueOnFail()) {
items=[{json:{ error: error.message }}]; items=[{json:{ error: error.message }}];
} else { } else {
// Try to find the lien number which contains the error and attach to error message // Try to find the line number which contains the error and attach to error message
const stackLines = error.stack.split('\n'); const stackLines = error.stack.split('\n');
if (stackLines.length > 0) { if (stackLines.length > 0) {
const lineParts = stackLines[1].split(':'); const lineParts = stackLines[1].split(':');

2
packages/nodes-base/nodes/FunctionItem/FunctionItem.node.ts
View file

@ -120,7 +120,7 @@ return item;`,
returnData.push({json:{ error: error.message }}); returnData.push({json:{ error: error.message }});
continue; continue;
} else { } else {
// Try to find the lien number which contains the error and attach to error message // Try to find the line number which contains the error and attach to error message
const stackLines = error.stack.split('\n'); const stackLines = error.stack.split('\n');
if (stackLines.length > 0) { if (stackLines.length > 0) {
const lineParts = stackLines[1].split(':'); const lineParts = stackLines[1].split(':');