mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: Remove triggers and actions experiment (no-changelog) (#6512)

Browse source 
* refactor: Remove triggers and actions experiment

* fix: Use `value` for computed property

* test: Fix e2e
This commit is contained in:
Iván Ovejero 2023-06-26 13:33:31 +02:00 committed by GitHub
parent 186271e939
commit b66d151066
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cypress/e2e/4-node-creator.cy.ts
View file

@ -271,7 +271,7 @@ describe('Node Creator', () => {
NDVModal.actions.close(); NDVModal.actions.close();
WorkflowPage.getters.canvasNodes().should('have.length', 2); WorkflowPage.getters.canvasNodes().should('have.length', 2);
WorkflowPage.actions.zoomToFit(); WorkflowPage.actions.zoomToFit();
WorkflowPage.actions.addNodeBetweenNodes('n8n', 'n8n1', 'Item Lists') WorkflowPage.actions.addNodeBetweenNodes('n8n', 'n8n1', 'Item Lists', 'Summarize')
WorkflowPage.getters.canvasNodes().should('have.length', 3); WorkflowPage.getters.canvasNodes().should('have.length', 3);
}) })
}); });

5
cypress/pages/workflow.ts
View file

@ -241,14 +241,15 @@ export class WorkflowPage extends BasePage {
executeWorkflow: () => { executeWorkflow: () => {
this.getters.executeWorkflowButton().click(); this.getters.executeWorkflowButton().click();
}, },
addNodeBetweenNodes: (sourceNodeName: string, targetNodeName: string, newNodeName: string) => { addNodeBetweenNodes: (sourceNodeName: string, targetNodeName: string, newNodeName: string, action?: string) => {
this.getters.getConnectionBetweenNodes(sourceNodeName, targetNodeName).first().realHover(); this.getters.getConnectionBetweenNodes(sourceNodeName, targetNodeName).first().realHover();
this.getters this.getters
.getConnectionActionsBetweenNodes(sourceNodeName, targetNodeName) .getConnectionActionsBetweenNodes(sourceNodeName, targetNodeName)
.find('.add') .find('.add')
.first() .first()
.click({ force: true }); .click({ force: true });
this.actions.addNodeToCanvas(newNodeName, false);
this.actions.addNodeToCanvas(newNodeName, false, false, action);
}, },
deleteNodeBetweenNodes: ( deleteNodeBetweenNodes: (
sourceNodeName: string, sourceNodeName: string,

8
packages/editor-ui/src/components/Node/NodeCreator/Modes/ActionsMode.vue
View file

@ -13,10 +13,8 @@ import {
REGULAR_NODE_CREATOR_VIEW, REGULAR_NODE_CREATOR_VIEW,
TRIGGER_NODE_CREATOR_VIEW, TRIGGER_NODE_CREATOR_VIEW,
CUSTOM_API_CALL_KEY, CUSTOM_API_CALL_KEY,
AUTO_INSERT_ACTION_EXPERIMENT,
} from '@/constants'; } from '@/constants';
import { usePostHog } from '@/stores/posthog.store';
import { useUsersStore } from '@/stores/users.store'; import { useUsersStore } from '@/stores/users.store';
import { useWebhooksStore } from '@/stores/webhooks.store'; import { useWebhooksStore } from '@/stores/webhooks.store';
import { runExternalHook } from '@/utils'; import { runExternalHook } from '@/utils';
@ -143,12 +141,8 @@ function onSelected(actionCreateElement: INodeCreateElement) {
const isPlaceholderTriggerAction = placeholderTriggerActions.some( const isPlaceholderTriggerAction = placeholderTriggerActions.some(
(p) => p.key === actionCreateElement.key, (p) => p.key === actionCreateElement.key,
); );
const includeNodeWithPlaceholderTrigger = usePostHog().isVariantEnabled(
AUTO_INSERT_ACTION_EXPERIMENT.name,
AUTO_INSERT_ACTION_EXPERIMENT.variant,
);
if (includeNodeWithPlaceholderTrigger && isPlaceholderTriggerAction && isTriggerRootView) { if (isPlaceholderTriggerAction && isTriggerRootView.value) {
const actionNode = actions.value[0].key; const actionNode = actions.value[0].key;
emit('nodeTypeSelected', [actionData.key as string, actionNode]); emit('nodeTypeSelected', [actionData.key as string, actionNode]);

12
packages/editor-ui/src/constants.ts
View file

@ -520,12 +520,6 @@ export const KEEP_AUTH_IN_NDV_FOR_NODES = [HTTP_REQUEST_NODE_TYPE, WEBHOOK_NODE_
export const MAIN_AUTH_FIELD_NAME = 'authentication'; export const MAIN_AUTH_FIELD_NAME = 'authentication';
export const NODE_RESOURCE_FIELD_NAME = 'resource'; export const NODE_RESOURCE_FIELD_NAME = 'resource';
export const AUTO_INSERT_ACTION_EXPERIMENT = {
name: '003_auto_insert_action',
control: 'control',
variant: 'variant',
};
export const TEMPLATE_EXPERIMENT = { export const TEMPLATE_EXPERIMENT = {
name: '002_remove_templates', name: '002_remove_templates',
control: 'control', control: 'control',
@ -538,11 +532,7 @@ export const ONBOARDING_EXPERIMENT = {
variant: 'variant', variant: 'variant',
}; };
export const EXPERIMENTS_TO_TRACK = [ export const EXPERIMENTS_TO_TRACK = [TEMPLATE_EXPERIMENT.name, ONBOARDING_EXPERIMENT.name];
TEMPLATE_EXPERIMENT.name,
AUTO_INSERT_ACTION_EXPERIMENT.name,
ONBOARDING_EXPERIMENT.name,
];
export const NODE_TYPES_EXCLUDED_FROM_OUTPUT_NAME_APPEND = [FILTER_NODE_TYPE]; export const NODE_TYPES_EXCLUDED_FROM_OUTPUT_NAME_APPEND = [FILTER_NODE_TYPE];