From b7951a071c7ab7f68e78812043f9ec90c02f39ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?=
 =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?=
 =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?=
 <netroy@users.noreply.github.com>
Date: Thu, 26 Sep 2024 14:15:11 +0200
Subject: [PATCH] refactor(editor): Convert Sticky component to Options API
 (no-changelog) (#10975)

---
 .../src/components/N8nMarkdown/Markdown.vue   |   4 +-
 .../N8nResizeableSticky/ResizeableSticky.vue  |   7 +-
 .../src/components/N8nSticky/Sticky.vue       |   4 +-
 packages/editor-ui/src/components/Sticky.vue  | 580 ++++++++----------
 4 files changed, 280 insertions(+), 315 deletions(-)

diff --git a/packages/design-system/src/components/N8nMarkdown/Markdown.vue b/packages/design-system/src/components/N8nMarkdown/Markdown.vue
index 7f55c0c6f1..1074d584bf 100644
--- a/packages/design-system/src/components/N8nMarkdown/Markdown.vue
+++ b/packages/design-system/src/components/N8nMarkdown/Markdown.vue
@@ -136,7 +136,7 @@ const htmlContent = computed(() => {
 });
 
 const emit = defineEmits<{
-	'markdown-click': [link: string, e: MouseEvent];
+	'markdown-click': [link: HTMLAnchorElement, e: MouseEvent];
 	'update-content': [content: string];
 }>();
 
@@ -154,7 +154,7 @@ const onClick = (event: MouseEvent) => {
 		}
 	}
 	if (clickedLink) {
-		emit('markdown-click', clickedLink?.href, event);
+		emit('markdown-click', clickedLink, event);
 	}
 };
 
diff --git a/packages/design-system/src/components/N8nResizeableSticky/ResizeableSticky.vue b/packages/design-system/src/components/N8nResizeableSticky/ResizeableSticky.vue
index ea72c506b7..5219efe2f4 100644
--- a/packages/design-system/src/components/N8nResizeableSticky/ResizeableSticky.vue
+++ b/packages/design-system/src/components/N8nResizeableSticky/ResizeableSticky.vue
@@ -21,6 +21,7 @@ const emit = defineEmits<{
 	resize: [values: ResizeData];
 	resizestart: [];
 	resizeend: [];
+	'markdown-click': [link: HTMLAnchorElement, e: MouseEvent];
 }>();
 
 const attrs = useAttrs();
@@ -42,6 +43,10 @@ const onResizeEnd = () => {
 	isResizing.value = false;
 	emit('resizeend');
 };
+
+const onMarkdownClick = (link: HTMLAnchorElement, event: MouseEvent) => {
+	emit('markdown-click', link, event);
+};
 </script>
 
 <template>
@@ -57,6 +62,6 @@ const onResizeEnd = () => {
 		@resize="onResize"
 		@resizestart="onResizeStart"
 	>
-		<N8nSticky v-bind="stickyBindings" />
+		<N8nSticky v-bind="stickyBindings" @markdown-click="onMarkdownClick" />
 	</N8nResizeWrapper>
 </template>
diff --git a/packages/design-system/src/components/N8nSticky/Sticky.vue b/packages/design-system/src/components/N8nSticky/Sticky.vue
index 73aa4933a3..569cd15974 100644
--- a/packages/design-system/src/components/N8nSticky/Sticky.vue
+++ b/packages/design-system/src/components/N8nSticky/Sticky.vue
@@ -13,7 +13,7 @@ const props = withDefaults(defineProps<StickyProps>(), defaultStickyProps);
 const emit = defineEmits<{
 	edit: [editing: boolean];
 	'update:modelValue': [value: string];
-	'markdown-click': [link: string, e: Event];
+	'markdown-click': [link: HTMLAnchorElement, e: MouseEvent];
 }>();
 
 const { t } = useI18n();
@@ -63,7 +63,7 @@ const onUpdateModelValue = (value: string) => {
 	emit('update:modelValue', value);
 };
 
-const onMarkdownClick = (link: string, event: Event) => {
+const onMarkdownClick = (link: HTMLAnchorElement, event: MouseEvent) => {
 	emit('markdown-click', link, event);
 };
 
diff --git a/packages/editor-ui/src/components/Sticky.vue b/packages/editor-ui/src/components/Sticky.vue
index 9888d6253d..0d11628901 100644
--- a/packages/editor-ui/src/components/Sticky.vue
+++ b/packages/editor-ui/src/components/Sticky.vue
@@ -1,19 +1,12 @@
-<script lang="ts">
-import { defineComponent, ref } from 'vue';
-import type { PropType, StyleValue } from 'vue';
-import { mapStores } from 'pinia';
-
+<script setup lang="ts">
+import { ref, computed, onMounted, nextTick } from 'vue';
+import type { StyleValue } from 'vue';
 import { onClickOutside } from '@vueuse/core';
+import type { Workflow } from 'n8n-workflow';
 
 import { isNumber, isString } from '@/utils/typeGuards';
-import type {
-	INodeUi,
-	INodeUpdatePropertiesInformation,
-	IUpdateInformation,
-	XYPosition,
-} from '@/Interface';
+import type { INodeUi, XYPosition } from '@/Interface';
 
-import type { INodeTypeDescription, Workflow } from 'n8n-workflow';
 import { QUICKSTART_NOTE_NAME } from '@/constants';
 import { useUIStore } from '@/stores/ui.store';
 import { useWorkflowsStore } from '@/stores/workflows.store';
@@ -25,313 +18,280 @@ import { GRID_SIZE } from '@/utils/nodeViewUtils';
 import { useToast } from '@/composables/useToast';
 import { assert } from '@/utils/assert';
 import type { BrowserJsPlumbInstance } from '@jsplumb/browser-ui';
-import { useCanvasStore } from '@/stores/canvas.store';
-import { useHistoryStore } from '@/stores/history.store';
 import { useNodeBase } from '@/composables/useNodeBase';
+import { useTelemetry } from '@/composables/useTelemetry';
 
-export default defineComponent({
-	name: 'Sticky',
-	props: {
-		nodeViewScale: {
-			type: Number,
-			default: 1,
-		},
-		gridSize: {
-			type: Number,
-			default: GRID_SIZE,
-		},
-		name: {
-			type: String,
-			required: true,
-		},
-		instance: {
-			type: Object as PropType<BrowserJsPlumbInstance>,
-			required: true,
-		},
-		isReadOnly: {
-			type: Boolean,
-		},
-		isActive: {
-			type: Boolean,
-		},
-		hideActions: {
-			type: Boolean,
-		},
-		disableSelecting: {
-			type: Boolean,
-		},
-		showCustomTooltip: {
-			type: Boolean,
-		},
-		workflow: {
-			type: Object as PropType<Workflow>,
-			required: true,
-		},
+const props = withDefaults(
+	defineProps<{
+		nodeViewScale?: number;
+		gridSize?: number;
+		name: string;
+		instance: BrowserJsPlumbInstance;
+		isReadOnly?: boolean;
+		isActive?: boolean;
+		hideActions?: boolean;
+		disableSelecting?: boolean;
+		showCustomTooltip?: boolean;
+		workflow: Workflow;
+	}>(),
+	{
+		nodeViewScale: 1,
+		gridSize: GRID_SIZE,
 	},
-	emits: { removeNode: null, nodeSelected: null },
-	setup(props, { emit }) {
-		const deviceSupport = useDeviceSupport();
-		const toast = useToast();
-		const forceActions = ref(false);
-		const isColorPopoverVisible = ref(false);
+);
 
-		const stickOptions = ref<HTMLElement>();
+defineOptions({ name: 'Sticky' });
 
-		const setForceActions = (value: boolean) => {
-			forceActions.value = value;
-		};
-		const setColorPopoverVisible = (value: boolean) => {
-			isColorPopoverVisible.value = value;
-		};
+const emit = defineEmits<{
+	removeNode: [string];
+	nodeSelected: [string, boolean, boolean];
+}>();
 
-		const contextMenu = useContextMenu((action) => {
-			if (action === 'change_color') {
-				setForceActions(true);
-				setColorPopoverVisible(true);
-			}
-		});
+const deviceSupport = useDeviceSupport();
+const telemetry = useTelemetry();
+const toast = useToast();
+const ndvStore = useNDVStore();
+const nodeTypesStore = useNodeTypesStore();
+const uiStore = useUIStore();
+const workflowsStore = useWorkflowsStore();
 
-		const nodeBase = useNodeBase({
-			name: props.name,
-			instance: props.instance,
-			workflowObject: props.workflow,
-			isReadOnly: props.isReadOnly,
-			emit: emit as (event: string, ...args: unknown[]) => void,
-		});
+const isResizing = ref<boolean>(false);
+const isTouchActive = ref<boolean>(false);
+const forceActions = ref(false);
+const isColorPopoverVisible = ref(false);
+const stickOptions = ref<HTMLElement>();
 
-		onClickOutside(stickOptions, () => setColorPopoverVisible(false));
+const setForceActions = (value: boolean) => {
+	forceActions.value = value;
+};
 
-		return {
-			deviceSupport,
-			toast,
-			contextMenu,
-			forceActions,
-			...nodeBase,
-			setForceActions,
-			isColorPopoverVisible,
-			setColorPopoverVisible,
-			stickOptions,
-		};
-	},
-	data() {
-		return {
-			isResizing: false,
-			isTouchActive: false,
-		};
-	},
-	computed: {
-		...mapStores(
-			useNodeTypesStore,
-			useUIStore,
-			useNDVStore,
-			useCanvasStore,
-			useWorkflowsStore,
-			useHistoryStore,
-		),
-		data(): INodeUi | null {
-			return this.workflowsStore.getNodeByName(this.name);
-		},
-		nodeId(): string {
-			return this.data?.id || '';
-		},
-		defaultText(): string {
-			if (!this.nodeType) {
-				return '';
-			}
-			const properties = this.nodeType.properties;
-			const content = properties.find((property) => property.name === 'content');
+const setColorPopoverVisible = (value: boolean) => {
+	isColorPopoverVisible.value = value;
+};
 
-			return content && isString(content.default) ? content.default : '';
-		},
-		isSelected(): boolean {
-			return (
-				this.uiStore.getSelectedNodes.find((node: INodeUi) => node.name === this.data?.name) !==
-				undefined
-			);
-		},
-		nodeType(): INodeTypeDescription | null {
-			return this.data && this.nodeTypesStore.getNodeType(this.data.type, this.data.typeVersion);
-		},
-		node(): INodeUi | null {
-			// same as this.data but reactive..
-			return this.workflowsStore.getNodeByName(this.name);
-		},
-		position(): XYPosition {
-			if (this.node) {
-				return this.node.position;
-			} else {
-				return [0, 0];
-			}
-		},
-		height(): number {
-			return this.node && isNumber(this.node.parameters.height) ? this.node.parameters.height : 0;
-		},
-		width(): number {
-			return this.node && isNumber(this.node.parameters.width) ? this.node.parameters.width : 0;
-		},
-		stickySize(): StyleValue {
-			const returnStyles: {
-				[key: string]: string | number;
-			} = {
-				height: this.height + 'px',
-				width: this.width + 'px',
-			};
-
-			return returnStyles;
-		},
-		stickyPosition(): StyleValue {
-			const returnStyles: {
-				[key: string]: string | number;
-			} = {
-				left: this.position[0] + 'px',
-				top: this.position[1] + 'px',
-				zIndex: this.isActive ? 9999999 : -1 * Math.floor((this.height * this.width) / 1000),
-			};
-
-			return returnStyles;
-		},
-		showActions(): boolean {
-			return (
-				!(this.hideActions || this.isReadOnly || this.workflowRunning || this.isResizing) ||
-				this.forceActions
-			);
-		},
-		workflowRunning(): boolean {
-			return this.uiStore.isActionActive['workflowRunning'];
-		},
-	},
-	mounted() {
-		// Initialize the node
-		if (this.data !== null) {
-			try {
-				this.addNode(this.data);
-			} catch (error) {
-				// This breaks when new nodes are loaded into store but workflow tab is not currently active
-				// Shouldn't affect anything
-			}
-		}
-	},
-	methods: {
-		onShowPopover() {
-			this.setForceActions(true);
-		},
-		onHidePopover() {
-			this.setForceActions(false);
-		},
-		async deleteNode() {
-			assert(this.data);
-			// Wait a tick else vue causes problems because the data is gone
-			await this.$nextTick();
-			this.$emit('removeNode', this.data.name);
-		},
-		changeColor(index: number) {
-			this.workflowsStore.updateNodeProperties({
-				name: this.name,
-				properties: {
-					parameters: {
-						...this.node?.parameters,
-						color: index,
-					},
-					position: this.node?.position ?? [0, 0],
-				},
-			});
-		},
-		onEdit(edit: boolean) {
-			if (edit && !this.isActive && this.node) {
-				this.ndvStore.activeNodeName = this.node.name;
-			} else if (this.isActive && !edit) {
-				this.ndvStore.activeNodeName = null;
-			}
-		},
-		onMarkdownClick(link: HTMLAnchorElement) {
-			if (link) {
-				const isOnboardingNote = this.name === QUICKSTART_NOTE_NAME;
-				const isWelcomeVideo = link.querySelector('img[alt="n8n quickstart video"]');
-				const type =
-					isOnboardingNote && isWelcomeVideo
-						? 'welcome_video'
-						: isOnboardingNote && link.getAttribute('href') === '/templates'
-							? 'templates'
-							: 'other';
-
-				this.$telemetry.track('User clicked note link', { type });
-			}
-		},
-		onInputChange(content: string) {
-			if (!this.node) {
-				return;
-			}
-			this.node.parameters.content = content;
-			this.setParameters({ content });
-		},
-		onResizeStart() {
-			this.isResizing = true;
-			if (!this.isSelected && this.node) {
-				this.$emit('nodeSelected', this.node.name, false, true);
-			}
-		},
-		onResize({ height, width, dX, dY }: { width: number; height: number; dX: number; dY: number }) {
-			if (!this.node) {
-				return;
-			}
-			if (dX !== 0 || dY !== 0) {
-				this.setPosition([this.node.position[0] + (dX || 0), this.node.position[1] + (dY || 0)]);
-			}
-
-			this.setParameters({ height, width });
-		},
-		onResizeEnd() {
-			this.isResizing = false;
-		},
-		setParameters(params: { content?: string; height?: number; width?: number; color?: string }) {
-			if (this.node) {
-				const nodeParameters = {
-					content: isString(params.content) ? params.content : this.node.parameters.content,
-					height: isNumber(params.height) ? params.height : this.node.parameters.height,
-					width: isNumber(params.width) ? params.width : this.node.parameters.width,
-					color: isString(params.color) ? params.color : this.node.parameters.color,
-				};
-
-				const updateInformation: IUpdateInformation = {
-					key: this.node.id,
-					name: this.node.name,
-					value: nodeParameters,
-				};
-
-				this.workflowsStore.setNodeParameters(updateInformation);
-			}
-		},
-		setPosition(position: XYPosition) {
-			if (!this.node) {
-				return;
-			}
-
-			const updateInformation: INodeUpdatePropertiesInformation = {
-				name: this.node.name,
-				properties: {
-					position,
-				},
-			};
-
-			this.workflowsStore.updateNodeProperties(updateInformation);
-		},
-		touchStart() {
-			if (this.deviceSupport.isTouchDevice && !this.deviceSupport.isMacOs && !this.isTouchActive) {
-				this.isTouchActive = true;
-				setTimeout(() => {
-					this.isTouchActive = false;
-				}, 2000);
-			}
-		},
-		onContextMenu(e: MouseEvent): void {
-			if (this.node && !this.isActive) {
-				this.contextMenu.open(e, { source: 'node-right-click', nodeId: this.node.id });
-			} else {
-				e.stopPropagation();
-			}
-		},
-	},
+const contextMenu = useContextMenu((action) => {
+	if (action === 'change_color') {
+		setForceActions(true);
+		setColorPopoverVisible(true);
+	}
 });
+
+const nodeBase = useNodeBase({
+	name: props.name,
+	instance: props.instance,
+	workflowObject: props.workflow,
+	isReadOnly: props.isReadOnly,
+	emit: emit as (event: string, ...args: unknown[]) => void,
+});
+
+onClickOutside(stickOptions, () => setColorPopoverVisible(false));
+
+defineExpose({
+	deviceSupport,
+	toast,
+	contextMenu,
+	forceActions,
+	...nodeBase,
+	setForceActions,
+	isColorPopoverVisible,
+	setColorPopoverVisible,
+	stickOptions,
+});
+
+const data = computed(() => workflowsStore.getNodeByName(props.name));
+// TODO: remove either node or data
+const node = computed(() => workflowsStore.getNodeByName(props.name));
+const nodeId = computed(() => data.value?.id);
+const nodeType = computed(() => {
+	return data.value && nodeTypesStore.getNodeType(data.value.type, data.value.typeVersion);
+});
+const defaultText = computed(() => {
+	if (!nodeType.value) {
+		return '';
+	}
+	const properties = nodeType.value.properties;
+	const content = properties.find((property) => property.name === 'content');
+	return content && isString(content.default) ? content.default : '';
+});
+const isSelected = computed(
+	() =>
+		uiStore.getSelectedNodes.find(({ name }: INodeUi) => name === data.value?.name) !== undefined,
+);
+
+const position = computed<XYPosition>(() => (node.value ? node.value.position : [0, 0]));
+
+const height = computed(() =>
+	node.value && isNumber(node.value.parameters.height) ? node.value.parameters.height : 0,
+);
+
+const width = computed(() =>
+	node.value && isNumber(node.value.parameters.width) ? node.value.parameters.width : 0,
+);
+
+const stickySize = computed<StyleValue>(() => ({
+	height: height.value + 'px',
+	width: width.value + 'px',
+}));
+
+const stickyPosition = computed<StyleValue>(() => ({
+	left: position.value[0] + 'px',
+	top: position.value[1] + 'px',
+	zIndex: props.isActive ? 9999999 : -1 * Math.floor((height.value * width.value) / 1000),
+}));
+
+const workflowRunning = computed(() => uiStore.isActionActive.workflowRunning);
+
+const showActions = computed(
+	() =>
+		!(props.hideActions || props.isReadOnly || workflowRunning.value || isResizing.value) ||
+		forceActions.value,
+);
+
+onMounted(() => {
+	// Initialize the node
+	if (data.value !== null) {
+		try {
+			nodeBase.addNode(data.value);
+		} catch (error) {
+			// This breaks when new nodes are loaded into store but workflow tab is not currently active
+			// Shouldn't affect anything
+		}
+	}
+});
+
+const onShowPopover = () => setForceActions(true);
+const onHidePopover = () => setForceActions(false);
+const deleteNode = async () => {
+	assert(data.value);
+	// Wait a tick else vue causes problems because the data is gone
+	await nextTick();
+
+	emit('removeNode', data.value.name);
+};
+
+const changeColor = (index: number) => {
+	workflowsStore.updateNodeProperties({
+		name: props.name,
+		properties: {
+			parameters: {
+				...node.value?.parameters,
+				color: index,
+			},
+			position: node.value?.position ?? [0, 0],
+		},
+	});
+};
+
+const onEdit = (edit: boolean) => {
+	if (edit && !props.isActive && node.value) {
+		ndvStore.activeNodeName = node.value.name;
+	} else if (props.isActive && !edit) {
+		ndvStore.activeNodeName = null;
+	}
+};
+
+const onMarkdownClick = (link: HTMLAnchorElement) => {
+	if (link) {
+		const isOnboardingNote = props.name === QUICKSTART_NOTE_NAME;
+		const isWelcomeVideo = link.querySelector('img[alt="n8n quickstart video"]');
+		const type =
+			isOnboardingNote && isWelcomeVideo
+				? 'welcome_video'
+				: isOnboardingNote && link.getAttribute('href') === '/templates'
+					? 'templates'
+					: 'other';
+
+		telemetry.track('User clicked note link', { type });
+	}
+};
+
+const setParameters = (params: {
+	content?: string;
+	height?: number;
+	width?: number;
+	color?: string;
+}) => {
+	if (node.value) {
+		const nodeParameters = {
+			content: isString(params.content) ? params.content : node.value.parameters.content,
+			height: isNumber(params.height) ? params.height : node.value.parameters.height,
+			width: isNumber(params.width) ? params.width : node.value.parameters.width,
+			color: isString(params.color) ? params.color : node.value.parameters.color,
+		};
+
+		workflowsStore.setNodeParameters({
+			key: node.value.id,
+			name: node.value.name,
+			value: nodeParameters,
+		});
+	}
+};
+
+const onInputChange = (content: string) => {
+	if (!node.value) {
+		return;
+	}
+	node.value.parameters.content = content;
+	setParameters({ content });
+};
+
+const setPosition = (newPosition: XYPosition) => {
+	if (!node.value) return;
+
+	workflowsStore.updateNodeProperties({
+		name: node.value.name,
+		properties: { position: newPosition },
+	});
+};
+
+const onResizeStart = () => {
+	isResizing.value = true;
+	if (!isSelected.value && node.value) {
+		emit('nodeSelected', node.value.name, false, true);
+	}
+};
+
+const onResize = ({
+	height,
+	width,
+	dX,
+	dY,
+}: {
+	width: number;
+	height: number;
+	dX: number;
+	dY: number;
+}) => {
+	if (!node.value) {
+		return;
+	}
+	if (dX !== 0 || dY !== 0) {
+		setPosition([node.value.position[0] + (dX || 0), node.value.position[1] + (dY || 0)]);
+	}
+
+	setParameters({ height, width });
+};
+
+const onResizeEnd = () => {
+	isResizing.value = false;
+};
+
+const touchStart = () => {
+	if (deviceSupport.isTouchDevice && !deviceSupport.isMacOs && !isTouchActive.value) {
+		isTouchActive.value = true;
+		setTimeout(() => {
+			isTouchActive.value = false;
+		}, 2000);
+	}
+};
+
+const onContextMenu = (e: MouseEvent): void => {
+	if (node.value && !props.isActive) {
+		contextMenu.open(e, { source: 'node-right-click', nodeId: node.value.id });
+	} else {
+		e.stopPropagation();
+	}
+};
 </script>
 
 <template>
@@ -355,9 +315,9 @@ export default defineComponent({
 			<div v-show="isSelected" class="select-sticky-background" />
 			<div
 				v-touch:start="touchStart"
-				v-touch:end="touchEnd"
+				v-touch:end="nodeBase.touchEnd"
 				class="sticky-box"
-				@click.left="mouseLeftClick"
+				@click.left="nodeBase.mouseLeftClick"
 				@contextmenu="onContextMenu"
 			>
 				<N8nResizeableSticky