mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡ Deactivate Asana Trigger webhhook validation

Browse source
This commit is contained in:
Jan Oberhauser 2020-09-16 23:57:27 +02:00
parent 2fee4396f1
commit b90f4fb3f6
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/nodes-base/nodes/Asana/AsanaTrigger.node.ts
View file

@ -197,6 +197,7 @@ export class AsanaTrigger implements INodeType {
// that no webhooks are registred anymore // that no webhooks are registred anymore
delete webhookData.webhookId; delete webhookData.webhookId;
delete webhookData.webhookEvents; delete webhookData.webhookEvents;
delete webhookData.hookSecret;
} }
return true; return true;
@ -233,13 +234,17 @@ export class AsanaTrigger implements INodeType {
return {}; return {};
} }
// Check if the request is valid // TODO: Had to be deactivated as it is currently not possible to get the secret
// (if the signature matches to data and hookSecret) // in production mode as the static data overwrites each other because the
const computedSignature = createHmac('sha256', webhookData.hookSecret as string).update(JSON.stringify(req.body)).digest('hex'); // two exist at the same time (create webhook [with webhookId] and receive
if (headerData['x-hook-signature'] !== computedSignature) { // webhook [with secret])
// Signature is not valid so ignore call // // Check if the request is valid
return {}; // // (if the signature matches to data and hookSecret)
} // const computedSignature = createHmac('sha256', webhookData.hookSecret as string).update(JSON.stringify(req.body)).digest('hex');
// if (headerData['x-hook-signature'] !== computedSignature) {
// // Signature is not valid so ignore call
// return {};
// }
return { return {
workflowData: [ workflowData: [