mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

ci: Introduce lint rule no-untyped-config-class-field (no-changelog) (#10436)

Browse source
This commit is contained in:
Iván Ovejero 2024-08-15 16:00:11 +02:00 committed by GitHub
parent 6bca879d4a
commit bb4582fa2f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/@n8n/config/.eslintrc.js
View file

@ -7,4 +7,13 @@ module.exports = {
extends: ['@n8n_io/eslint-config/node'],
...sharedOptions(__dirname),
overrides: [
{
files: ['**/*.config.ts'],
rules: {
'n8n-local-rules/no-untyped-config-class-field': 'error',
},
},
],
};

23
packages/@n8n_io/eslint-config/local-rules.js
View file

@ -492,6 +492,29 @@ module.exports = {
};
},
},
'no-untyped-config-class-field': {
meta: {
type: 'problem',
docs: {
description: 'Enforce explicit typing of config class fields',
recommended: 'error',
},
messages: {
noUntypedConfigClassField:
'Class field must have an explicit type annotation, e.g. `field: type = value`. See: https://github.com/n8n-io/n8n/pull/10433',
},
},
create(context) {
return {
PropertyDefinition(node) {
if (!node.typeAnnotation) {
context.report({ node: node.key, messageId: 'noUntypedConfigClassField' });
}
},
};
},
},
};
const isJsonParseCall = (node) =>