mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-12 05:17:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Prevent axios from force setting a form-urlencoded content-type (#8117)

Browse source 
[Since v1 axios is force-setting a content-type of
`application/x-www-form-urlencoded` on POST/PUT/PATCH requests, even if
they have no
payload](https://github.com/axios/axios/blob/v1.x/lib/core/dispatchRequest.js#L45-L47).
This is causing nodes that do not support form-urlencoded bodies to
fail.
By setting the content-type to `false` (if a content-type wasn't already
set), we force axios to not overwrite this header.

[Workflows tests](https://github.com/n8n-io/n8n/actions/runs/7288103743/job/19860060607)
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-12-21 13:32:04 +01:00 committed by GitHub
parent 32d397eff3
commit bba95761e2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/core/src/NodeExecuteFunctions.ts
View file

@ -162,6 +162,13 @@ axios.defaults.paramsSerializer = (params) => {
} }
return stringify(params, { arrayFormat: 'indices' }); return stringify(params, { arrayFormat: 'indices' });
}; };
axios.interceptors.request.use((config) => {
// If no content-type is set by us, prevent axios from force-setting the content-type to `application/x-www-form-urlencoded`
if (config.data === undefined) {
config.headers.setContentType(false, false);
}
return config;
});
const pushFormDataValue = (form: FormData, key: string, value: any) => { const pushFormDataValue = (form: FormData, key: string, value: any) => {
if (value?.hasOwnProperty('value') && value.hasOwnProperty('options')) { if (value?.hasOwnProperty('value') && value.hasOwnProperty('options')) {