mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-14 16:44:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

🔨 Move tags validation to top

Browse source
This commit is contained in:
Iván Ovejero 2021-04-15 13:56:20 +02:00
parent 73a558b7e2
commit bd1b81eefc
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/cli/src/Server.ts
View file

@ -598,6 +598,14 @@ class App {
// Updates an existing workflow // Updates an existing workflow
this.app.patch(`/${this.restEndpoint}/workflows/:id`, ResponseHelper.send(async (req: IWorkflowRequest, res: express.Response): Promise<IWorkflowResponse> => { this.app.patch(`/${this.restEndpoint}/workflows/:id`, ResponseHelper.send(async (req: IWorkflowRequest, res: express.Response): Promise<IWorkflowResponse> => {
const { tags } = req.body; const { tags } = req.body;
const tagIds = tags;
if (tagIds) {
await TagHelpers.validateTags(tagIds);
await TagHelpers.validateNotRelated(req.params.id, tagIds);
}
const newWorkflowData = _.omit(req.body, ['tags']) as IWorkflowBase; const newWorkflowData = _.omit(req.body, ['tags']) as IWorkflowBase;
const id = req.params.id; const id = req.params.id;
@ -667,15 +675,9 @@ class App {
} }
} }
const workflowId = id;
const tagIds = tags;
if (tagIds) { if (tagIds) {
await TagHelpers.validateTags(tagIds); await TagHelpers.removeRelations(req.params.id);
await TagHelpers.validateNotRelated(workflowId, tagIds); await TagHelpers.createRelations(req.params.id, tagIds);
await TagHelpers.removeRelations(workflowId);
await TagHelpers.createRelations(workflowId, tagIds);
const found = await Db.collections.Tag!.find({ const found = await Db.collections.Tag!.find({
select: ['id', 'name'], select: ['id', 'name'],