mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Disable fromAI button for vector stores (#13125)

Browse source
This commit is contained in:
Charlie Kolb 2025-02-10 09:51:18 +01:00 committed by GitHub
parent 814e2a8924
commit bde84205f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/editor-ui/src/utils/fromAIOverrideUtils.test.ts
View file

@ -54,6 +54,17 @@ const AI_DENYLIST_NODE_TYPE: INodeTypeDescription = {
...MOCK_NODE_TYPE_MIXIN, ...MOCK_NODE_TYPE_MIXIN,
}; };
const AI_VECTOR_STORE_NODE_TYPE: INodeTypeDescription = {
name: 'aVectorStore',
codex: {
categories: ['AI'],
subcategories: {
AI: ['Tools', 'Vector Stores'],
},
},
...MOCK_NODE_TYPE_MIXIN,
};
const NON_AI_NODE_TYPE: INodeTypeDescription = { const NON_AI_NODE_TYPE: INodeTypeDescription = {
name: 'AN_NOT_AI_NODE_TYPE', name: 'AN_NOT_AI_NODE_TYPE',
...MOCK_NODE_TYPE_MIXIN, ...MOCK_NODE_TYPE_MIXIN,
@ -64,6 +75,8 @@ describe('makeOverrideValue', () => {
['null nodeType', makeContext(''), null], ['null nodeType', makeContext(''), null],
['non-ai node type', makeContext(''), NON_AI_NODE_TYPE], ['non-ai node type', makeContext(''), NON_AI_NODE_TYPE],
['ai node type on denylist', makeContext(''), AI_DENYLIST_NODE_TYPE], ['ai node type on denylist', makeContext(''), AI_DENYLIST_NODE_TYPE],
['vector store type', makeContext(''), AI_VECTOR_STORE_NODE_TYPE],
['denied parameter name', makeContext('', 'parameters.toolName'), AI_NODE_TYPE],
])('should not create an override for %s', (_name, context, nodeType) => { ])('should not create an override for %s', (_name, context, nodeType) => {
expect(makeOverrideValue(context, nodeType)).toBeNull(); expect(makeOverrideValue(context, nodeType)).toBeNull();
}); });

8
packages/editor-ui/src/utils/fromAIOverrideUtils.ts
View file

@ -48,6 +48,8 @@ const NODE_DENYLIST = ['toolCode', 'toolHttpRequest'];
const PATH_DENYLIST = [ const PATH_DENYLIST = [
'parameters.name', 'parameters.name',
// this is used in vector store tools
'parameters.toolName',
'parameters.description', 'parameters.description',
// This is used in e.g. the telegram node if the dropdown selects manual mode // This is used in e.g. the telegram node if the dropdown selects manual mode
'parameters.toolDescription', 'parameters.toolDescription',
@ -164,7 +166,11 @@ export function canBeContentOverride(
if (PATH_DENYLIST.includes(props.path)) return false; if (PATH_DENYLIST.includes(props.path)) return false;
const codex = nodeType?.codex; const codex = nodeType?.codex;
if (!codex?.categories?.includes('AI') || !codex?.subcategories?.AI?.includes('Tools')) if (
!codex?.categories?.includes('AI') ||
!codex?.subcategories?.AI?.includes('Tools') ||
codex?.subcategories?.AI?.includes('Vector Stores') // vector stores do not support fromAI
)
return false; return false;
return !props.parameter.noDataExpression && 'options' !== props.parameter.type; return !props.parameter.noDataExpression && 'options' !== props.parameter.type;