mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(FTP Node): Use filename instead of remote filepath for downloaded binary data (#6170)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-05-05 12:32:49 +00:00 committed by GitHub
parent 85a6ace56b
commit be089331b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/nodes-base/nodes/Ftp/Ftp.node.ts
View file

@ -601,11 +601,11 @@ export class Ftp implements INodeType {
await sftp!.get(path, createWriteStream(binaryFile.path)); await sftp!.get(path, createWriteStream(binaryFile.path));
const dataPropertyNameDownload = this.getNodeParameter('binaryPropertyName', i); const dataPropertyNameDownload = this.getNodeParameter('binaryPropertyName', i);
const filePathDownload = this.getNodeParameter('path', i) as string; const remoteFilePath = this.getNodeParameter('path', i) as string;
items[i].binary![dataPropertyNameDownload] = await this.nodeHelpers.copyBinaryFile( items[i].binary![dataPropertyNameDownload] = await this.nodeHelpers.copyBinaryFile(
binaryFile.path, binaryFile.path,
filePathDownload, basename(remoteFilePath),
); );
const executionData = this.helpers.constructExecutionMetaData( const executionData = this.helpers.constructExecutionMetaData(
@ -697,11 +697,11 @@ export class Ftp implements INodeType {
await streamPipeline(stream, createWriteStream(binaryFile.path)); await streamPipeline(stream, createWriteStream(binaryFile.path));
const dataPropertyNameDownload = this.getNodeParameter('binaryPropertyName', i); const dataPropertyNameDownload = this.getNodeParameter('binaryPropertyName', i);
const filePathDownload = this.getNodeParameter('path', i) as string; const remoteFilePath = this.getNodeParameter('path', i) as string;
items[i].binary![dataPropertyNameDownload] = await this.nodeHelpers.copyBinaryFile( items[i].binary![dataPropertyNameDownload] = await this.nodeHelpers.copyBinaryFile(
binaryFile.path, binaryFile.path,
filePathDownload, basename(remoteFilePath),
); );
const executionData = this.helpers.constructExecutionMetaData( const executionData = this.helpers.constructExecutionMetaData(