mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(Execute Workflow Node): Remove ignoreTypeMismatch option (no-changelog) (#12482)

Browse source
This commit is contained in:
Charlie Kolb 2025-01-07 15:57:03 +01:00 committed by GitHub
parent 30f9c033db
commit c03fe0af38
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 1 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cypress/fixtures/Test_Subworkflow-Inputs.json
View file

@ -19,7 +19,6 @@
"value": {}, "value": {},
"matchingColumns": [], "matchingColumns": [],
"schema": [], "schema": [],
"ignoreTypeMismatchErrors": false,
"attemptToConvertTypes": false, "attemptToConvertTypes": false,
"convertFieldsToString": true "convertFieldsToString": true
}, },

6
packages/core/src/node-execution-context/utils/validateValueAgainstSchema.ts
View file

@ -61,11 +61,7 @@ const validateResourceMapperValue = (
}); });
if (!validationResult.valid) { if (!validationResult.valid) {
if (!resourceMapperField.ignoreTypeMismatchErrors) { return { ...validationResult, fieldName: key };
return { ...validationResult, fieldName: key };
} else {
paramValues[key] = resolvedValue;
}
} else { } else {
// If it's valid, set the casted value // If it's valid, set the casted value
paramValues[key] = validationResult.newValue; paramValues[key] = validationResult.newValue;

18
packages/editor-ui/src/components/ResourceMapper/ResourceMapper.vue
View file

@ -63,7 +63,6 @@ const state = reactive({
value: {}, value: {},
matchingColumns: [] as string[], matchingColumns: [] as string[],
schema: [] as ResourceMapperField[], schema: [] as ResourceMapperField[],
ignoreTypeMismatchErrors: false,
attemptToConvertTypes: false, attemptToConvertTypes: false,
// This should always be true if `showTypeConversionOptions` is provided // This should always be true if `showTypeConversionOptions` is provided
// It's used to avoid accepting any value as string without casting it // It's used to avoid accepting any value as string without casting it
@ -664,23 +663,6 @@ defineExpose({
} }
" "
/> />
<ParameterInputFull
:parameter="{
name: 'ignoreTypeMismatchErrors',
type: 'boolean',
displayName: locale.baseText('resourceMapper.ignoreTypeMismatchErrors.displayName'),
default: false,
description: locale.baseText('resourceMapper.ignoreTypeMismatchErrors.description'),
}"
:path="props.path + '.ignoreTypeMismatchErrors'"
:value="state.paramValue.ignoreTypeMismatchErrors"
@update="
(x: IUpdateInformation<NodeParameterValueType>) => {
state.paramValue.ignoreTypeMismatchErrors = x.value as boolean;
emitValueChanged();
}
"
/>
</div> </div>
</div> </div>
</template> </template>

2
packages/editor-ui/src/plugins/i18n/locales/en.json
View file

@ -1600,8 +1600,6 @@
"resourceMapper.staleDataWarning.notice": "Refresh to see the updated fields", "resourceMapper.staleDataWarning.notice": "Refresh to see the updated fields",
"resourceMapper.attemptToConvertTypes.displayName": "Attempt to convert types", "resourceMapper.attemptToConvertTypes.displayName": "Attempt to convert types",
"resourceMapper.attemptToConvertTypes.description": "Attempt to convert types when mapping fields", "resourceMapper.attemptToConvertTypes.description": "Attempt to convert types when mapping fields",
"resourceMapper.ignoreTypeMismatchErrors.displayName": "Ignore type mismatch errors",
"resourceMapper.ignoreTypeMismatchErrors.description": "Whether type mismatches should be ignored, rather than returning an Error",
"runData.openSubExecution": "Inspect Sub-Execution {id}", "runData.openSubExecution": "Inspect Sub-Execution {id}",
"runData.openParentExecution": "Inspect Parent Execution {id}", "runData.openParentExecution": "Inspect Parent Execution {id}",
"runData.emptyItemHint": "This is an item, but it's empty.", "runData.emptyItemHint": "This is an item, but it's empty.",

1
packages/workflow/src/Interfaces.ts
View file

@ -2710,7 +2710,6 @@ export type ResourceMapperValue = {
value: { [key: string]: string | number | boolean | null } | null; value: { [key: string]: string | number | boolean | null } | null;
matchingColumns: string[]; matchingColumns: string[];
schema: ResourceMapperField[]; schema: ResourceMapperField[];
ignoreTypeMismatchErrors: boolean;
attemptToConvertTypes: boolean; attemptToConvertTypes: boolean;
convertFieldsToString: boolean; convertFieldsToString: boolean;
}; };