mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Don't show pin button in input panel when there's binary data (#11267)

Browse source
This commit is contained in:
Mutasem Aldmour 2024-10-21 15:00:15 +02:00 committed by GitHub
parent fed7c3ec1f
commit c0b5b92f62
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 60 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/editor-ui/src/components/RunData.vue
View file

@ -256,11 +256,19 @@ export default defineComponent({
return this.nodeTypesStore.isTriggerNode(this.node.type);
},
showPinButton(): boolean {
return Boolean(
(this.canPinData || this.pinnedData.hasData.value || !!this.binaryData?.length) &&
(this.rawInputData.length || this.pinnedData.hasData.value) &&
!this.editMode.enabled,
);
if (!this.rawInputData.length && !this.pinnedData.hasData.value) {
return false;
}
if (this.editMode.enabled) {
return false;
}
if (this.binaryData?.length) {
return this.isPaneTypeOutput;
}
return this.canPinData;
},
pinButtonDisabled(): boolean {
return (

49
packages/editor-ui/src/components/__tests__/RunData.test.ts
View file

@ -6,7 +6,7 @@ import RunData from '@/components/RunData.vue';
import { SET_NODE_TYPE, STORES, VIEWS } from '@/constants';
import { SETTINGS_STORE_DEFAULT_STATE } from '@/__tests__/utils';
import { createComponentRenderer } from '@/__tests__/render';
import type { INodeUi, IRunDataDisplayMode } from '@/Interface';
import type { INodeUi, IRunDataDisplayMode, NodePanelType } from '@/Interface';
import { useWorkflowsStore } from '@/stores/workflows.store';
import { setActivePinia } from 'pinia';
import { defaultNodeTypes } from '@/__tests__/mocks';
@ -24,6 +24,47 @@ const nodes = [
] as INodeUi[];
describe('RunData', () => {
it("should render pin button in output panel disabled when there's binary data", () => {
const { getByTestId } = render(
[
{
json: {},
binary: {
data: {
fileName: 'test.xyz',
mimeType: 'application/octet-stream',
},
},
},
],
'binary',
);
expect(getByTestId('ndv-pin-data')).toBeInTheDocument();
expect(getByTestId('ndv-pin-data')).toHaveAttribute('disabled');
});
it("should not render pin button in input panel when there's binary data", () => {
const { queryByTestId } = render(
[
{
json: {},
binary: {
data: {
fileName: 'test.xyz',
mimeType: 'application/octet-stream',
},
},
},
],
'binary',
undefined,
'input',
);
expect(queryByTestId('ndv-pin-data')).not.toBeInTheDocument();
});
it('should render data correctly even when "item.json" has another "json" key', async () => {
const { getByText, getAllByTestId, getByTestId } = render(
[
@ -117,6 +158,7 @@ describe('RunData', () => {
outputData: unknown[],
displayMode: IRunDataDisplayMode,
pinnedData?: INodeExecutionData[],
paneType: NodePanelType = 'output',
) => {
const pinia = createTestingPinia({
initialState: {
@ -196,6 +238,9 @@ describe('RunData', () => {
};
},
global: {
stubs: {
RunDataPinButton: { template: '<button data-test-id="ndv-pin-data"></button>' },
},
mocks: {
$route: {
name: VIEWS.WORKFLOW,
@ -211,7 +256,7 @@ describe('RunData', () => {
},
nodes: [{ name: 'Test Node', indicies: [], depth: 1 }],
runIndex: 0,
paneType: 'output',
paneType,
isExecuting: false,
mappingEnabled: true,
distanceFromActive: 0,