mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Wait Node): Prevent waiting until invalid date (#10523)

Browse source
This commit is contained in:
Iván Ovejero 2024-08-27 16:45:08 +02:00 committed by GitHub
parent fd58a272e1
commit c0e7620036
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/nodes-base/nodes/Wait/Wait.node.ts
View file

@ -7,7 +7,7 @@ import type {
IDisplayOptions, IDisplayOptions,
IWebhookFunctions, IWebhookFunctions,
} from 'n8n-workflow'; } from 'n8n-workflow';
import { WAIT_TIME_UNLIMITED } from 'n8n-workflow'; import { WAIT_TIME_UNLIMITED, NodeOperationError } from 'n8n-workflow';
import { import {
authenticationProperty, authenticationProperty,
@ -346,6 +346,7 @@ export class Wait extends Webhook {
}, },
default: '', default: '',
description: 'The date and time to wait for before continuing', description: 'The date and time to wait for before continuing',
required: true,
}, },
// ---------------------------------- // ----------------------------------
@ -492,6 +493,13 @@ export class Wait extends Webhook {
} else { } else {
const dateTimeStr = context.getNodeParameter('dateTime', 0) as string; const dateTimeStr = context.getNodeParameter('dateTime', 0) as string;
if (isNaN(Date.parse(dateTimeStr))) {
throw new NodeOperationError(
context.getNode(),
'[Wait node] Cannot put execution to wait because `dateTime` parameter is not a valid date. Please pick a specific date and time to wait until.',
);
}
waitTill = DateTime.fromFormat(dateTimeStr, "yyyy-MM-dd'T'HH:mm:ss", { waitTill = DateTime.fromFormat(dateTimeStr, "yyyy-MM-dd'T'HH:mm:ss", {
zone: context.getTimezone(), zone: context.getTimezone(),
}) })