From c0ec990f4cc78909e963b82f1492dafafab23b5a Mon Sep 17 00:00:00 2001 From: Elias Meire Date: Fri, 31 May 2024 18:04:57 +0200 Subject: [PATCH] feat(editor): Overhaul input selector in NDV (#9520) --- cypress/pages/ndv.ts | 6 +- .../src/components/InputNodeSelect.vue | 193 ++++++++++++++++ .../editor-ui/src/components/InputPanel.vue | 186 +++++---------- .../src/components/NodeDetailsView.vue | 1 + .../editor-ui/src/components/OutputPanel.vue | 15 +- packages/editor-ui/src/components/RunData.vue | 218 +++++++++++------- .../src/components/RunDataSearch.vue | 16 +- .../src/plugins/i18n/locales/en.json | 5 +- packages/editor-ui/src/utils/typesUtils.ts | 4 + 9 files changed, 428 insertions(+), 216 deletions(-) create mode 100644 packages/editor-ui/src/components/InputNodeSelect.vue diff --git a/cypress/pages/ndv.ts b/cypress/pages/ndv.ts index 23a9882747..6adca4befd 100644 --- a/cypress/pages/ndv.ts +++ b/cypress/pages/ndv.ts @@ -63,7 +63,9 @@ export class NDV extends BasePage { httpRequestNotice: () => cy.getByTestId('node-parameters-http-notice'), nthParam: (n: number) => cy.getByTestId('node-parameters').find('.parameter-item').eq(n), inputRunSelector: () => this.getters.inputPanel().findChildByTestId('run-selector'), + inputLinkRun: () => this.getters.inputPanel().findChildByTestId('link-run'), outputRunSelector: () => this.getters.outputPanel().findChildByTestId('run-selector'), + outputLinkRun: () => this.getters.outputPanel().findChildByTestId('link-run'), outputHoveringItem: () => this.getters.outputPanel().findChildByTestId('hovering-item'), inputHoveringItem: () => this.getters.inputPanel().findChildByTestId('hovering-item'), outputBranches: () => this.getters.outputPanel().findChildByTestId('branches'), @@ -228,10 +230,10 @@ export class NDV extends BasePage { getVisibleSelect().find('.el-select-dropdown__item').contains(runName).click(); }, toggleOutputRunLinking: () => { - this.getters.outputRunSelector().find('button').click(); + this.getters.outputLinkRun().click(); }, toggleInputRunLinking: () => { - this.getters.inputRunSelector().find('button').click(); + this.getters.inputLinkRun().click(); }, switchOutputBranch: (name: string) => { this.getters.outputBranches().get('span').contains(name).click(); diff --git a/packages/editor-ui/src/components/InputNodeSelect.vue b/packages/editor-ui/src/components/InputNodeSelect.vue new file mode 100644 index 0000000000..d8a38b830b --- /dev/null +++ b/packages/editor-ui/src/components/InputNodeSelect.vue @@ -0,0 +1,193 @@ + + + + + diff --git a/packages/editor-ui/src/components/InputPanel.vue b/packages/editor-ui/src/components/InputPanel.vue index ea8b591c8c..ead2b66e16 100644 --- a/packages/editor-ui/src/components/InputPanel.vue +++ b/packages/editor-ui/src/components/InputPanel.vue @@ -1,6 +1,7 @@