From c18ba370d55e658f74fbf5e78e19fe96dc58ec7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Thu, 14 Sep 2023 16:55:06 +0200 Subject: [PATCH] ci: Remove eslint diff plugin. Run full linting on PRs (no-changelog) (#7175) --- .github/workflows/ci-pull-requests.yml | 7 +------ packages/@n8n_io/eslint-config/base.js | 16 ---------------- packages/@n8n_io/eslint-config/package.json | 1 - .../__tests__/ResourceMapper.test.ts | 1 - pnpm-lock.yaml | 18 +++--------------- 5 files changed, 4 insertions(+), 39 deletions(-) diff --git a/.github/workflows/ci-pull-requests.yml b/.github/workflows/ci-pull-requests.yml index c952e91b6c..e87b1a6d92 100644 --- a/.github/workflows/ci-pull-requests.yml +++ b/.github/workflows/ci-pull-requests.yml @@ -67,10 +67,5 @@ jobs: path: ./packages/**/dist key: ${{ github.sha }}-base:18-test-lint - - name: Fetch base branch for `git diff` - run: git fetch origin ${{ github.event.pull_request.base.ref }}:${{ github.event.pull_request.base.ref }} - - - name: Run ESLint on changes only - env: - ESLINT_PLUGIN_DIFF_COMMIT: ${{ github.event.pull_request.base.ref }} + - name: Lint run: pnpm lint diff --git a/packages/@n8n_io/eslint-config/base.js b/packages/@n8n_io/eslint-config/base.js index 0026cfa63f..bdf78918c3 100644 --- a/packages/@n8n_io/eslint-config/base.js +++ b/packages/@n8n_io/eslint-config/base.js @@ -491,19 +491,3 @@ const config = (module.exports = { }, ], }); - -if ('ESLINT_PLUGIN_DIFF_COMMIT' in process.env) { - /** - * Plugin to lint only changes - * - * https://github.com/paleite/eslint-plugin-diff#plugindiffdiff-recommended - */ - config.plugins.push('eslint-plugin-diff'); - - /** - * Config for eslint-plugin-diff - * - * https://github.com/paleite/eslint-plugin-diff#plugindiffdiff-recommended - */ - config.extends.push('plugin:diff/diff'); -} diff --git a/packages/@n8n_io/eslint-config/package.json b/packages/@n8n_io/eslint-config/package.json index 9502402f6c..18cc51681a 100644 --- a/packages/@n8n_io/eslint-config/package.json +++ b/packages/@n8n_io/eslint-config/package.json @@ -11,7 +11,6 @@ "eslint-config-airbnb-typescript": "^17.1.0", "eslint-config-prettier": "^8.9.0", "eslint-import-resolver-typescript": "^3.5.5", - "eslint-plugin-diff": "^2.0.1", "eslint-plugin-import": "^2.28.0", "eslint-plugin-n8n-local-rules": "^1.0.0", "eslint-plugin-prettier": "^5.0.0", diff --git a/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts b/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts index 4d270d5ef3..00e0fb967d 100644 --- a/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts +++ b/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts @@ -3,7 +3,6 @@ import { MAPPING_COLUMNS_RESPONSE, NODE_PARAMETER_VALUES, UPDATED_SCHEMA, - getLatestValueChangeEvent, } from './utils/ResourceMapper.utils'; import { useNodeTypesStore } from '@/stores/nodeTypes.store'; import { waitAllPromises } from '@/__tests__/utils'; diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index efcfc7c8cf..b7a4dc8180 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -167,9 +167,6 @@ importers: eslint-import-resolver-typescript: specifier: ^3.5.5 version: 3.5.5(@typescript-eslint/parser@6.2.0)(eslint-plugin-import@2.28.0)(eslint@8.45.0) - eslint-plugin-diff: - specifier: ^2.0.1 - version: 2.0.1(eslint@8.45.0) eslint-plugin-import: specifier: ^2.28.0 version: 2.28.0(@typescript-eslint/parser@6.2.0)(eslint-import-resolver-typescript@3.5.5)(eslint@8.45.0) @@ -6765,7 +6762,7 @@ packages: ts-dedent: 2.2.0 type-fest: 3.13.1 vue: 3.3.4 - vue-component-type-helpers: 1.8.10 + vue-component-type-helpers: 1.8.11 transitivePeerDependencies: - encoding - supports-color @@ -11750,15 +11747,6 @@ packages: - supports-color dev: true - /eslint-plugin-diff@2.0.1(eslint@8.45.0): - resolution: {integrity: sha512-qqbvwaaO1cfkUprliqiRojRsD0qGsvzmJNqNrb9s0h15sDVzZMXYdu0TUFpUwauLeU28etSsfWIp0Uu+OAcXXw==} - engines: {node: '>=14.0.0'} - peerDependencies: - eslint: '>=6.7.0' - dependencies: - eslint: 8.45.0 - dev: true - /eslint-plugin-import@2.28.0(@typescript-eslint/parser@6.2.0)(eslint-import-resolver-typescript@3.5.5)(eslint@8.45.0): resolution: {integrity: sha512-B8s/n+ZluN7sxj9eUf7/pRFERX0r5bnFA2dCaLHy2ZeaQEAz0k+ZZkFWRFHJAqxfxQDx6KLv9LeIki7cFdwW+Q==} engines: {node: '>=4'} @@ -21744,8 +21732,8 @@ packages: vue: 3.3.4 dev: false - /vue-component-type-helpers@1.8.10: - resolution: {integrity: sha512-FJtmfw2Gn6eQ8kAVNEhw9nYIzWmVQJjdyQRtJXZ7tgXh/FoZhQnZ2KyxR+NuF9U4iZLBvSspeetIpnP9yxxyMw==} + /vue-component-type-helpers@1.8.11: + resolution: {integrity: sha512-CWItFzuEWjkSXDeMGwQEc5cFH4FaueyPQHfi1mBDe+wA2JABqNjFxFUtmZJ9WHkb0HpEwqgBg1umiXrWYXkXHw==} dev: true /vue-component-type-helpers@1.8.4: