feat(editor): Refactor several smaller components to composition API (no-changelog) (#10038)

packages/editor-ui/src/components/Banner.vue

@@ -35,51 +35,41 @@
 	</el-tag>
 </template>
 
-<script lang="ts">
+<script setup lang="ts">
-import { defineComponent } from 'vue';
+import { ref } from 'vue';
 
-export default defineComponent({
+interface Props {
-	name: 'Banner',
+	theme: 'success' | 'danger';
-	props: {
+	message: string;
-		theme: {
+	buttonLabel?: string;
-			type: String,
+	buttonLoadingLabel?: string;
-			validator: (value: string): boolean => ['success', 'danger'].indexOf(value) !== -1,
+	buttonTitle?: string;
-		},
+	details?: string;
-		message: {
+	buttonLoading?: boolean;
-			type: String,
+}
-		},
+
-		buttonLabel: {
+withDefaults(defineProps<Props>(), {
-			type: String,
+	buttonLoading: false,
-		},
+	buttonLabel: '',
-		buttonLoadingLabel: {
+	buttonLoadingLabel: '',
-			type: String,
+	buttonTitle: '',
-		},
+	details: '',
-		buttonTitle: {
-			type: String,
-		},
-		details: {
-			type: String,
-		},
-		buttonLoading: {
-			type: Boolean,
-			default: false,
-		},
-	},
-	data() {
-		return {
-			expanded: false,
-		};
-	},
-	methods: {
-		expand() {
-			this.expanded = true;
-		},
-		onClick() {
-			this.expanded = false;
-			this.$emit('click');
-		},
-	},
 });
+
+const emit = defineEmits<{
+	click: [];
+}>();
+
+const expanded = ref(false);
+
+const expand = () => {
+	expanded.value = true;
+};
+
+const onClick = () => {
+	expanded.value = false;
+	emit('click');
+};
 </script>
 
 <style module lang="scss">

packages/editor-ui/src/components/CollectionWorkflowCard.vue

@@ -1,6 +1,6 @@
 <template>
 	<n8n-card :class="$style.card" v-bind="$attrs">
-		<template v-if="!loading" #header>
+		<template v-if="!loading && title" #header>
 			<span :class="$style.title" v-text="title" />
 		</template>
 		<n8n-loading :loading="loading" :rows="3" variant="p" />
@@ -10,20 +10,11 @@
 	</n8n-card>
 </template>
 
-<script lang="ts">
+<script lang="ts" setup>
-import { defineComponent } from 'vue';
+defineProps<{
-
+	loading: boolean;
-export default defineComponent({
+	title?: string;
-	name: 'Card',
+}>();
-	props: {
-		loading: {
-			type: Boolean,
-		},
-		title: {
-			type: String,
-		},
-	},
-});
 </script>
 
 <style lang="scss" module>

packages/editor-ui/src/components/GoBackButton.vue

@@ -5,27 +5,15 @@
 	</div>
 </template>
 
-<script lang="ts">
+<script setup lang="ts">
-import { defineComponent } from 'vue';
+import { useRouter } from 'vue-router';
 import { VIEWS } from '@/constants';
 
-export default defineComponent({
+const router = useRouter();
-	name: 'GoBackButton',
+
-	data() {
+const navigateTo = () => {
-		return {
+	void router.push({ name: VIEWS.TEMPLATES });
-			routeHasHistory: false,
 };
-	},
-	mounted() {
-		window.history.state ? (this.routeHasHistory = true) : (this.routeHasHistory = false);
-	},
-	methods: {
-		navigateTo() {
-			if (this.routeHasHistory) this.$router.go(-1);
-			else void this.$router.push({ name: VIEWS.TEMPLATES });
-		},
-	},
-});
 </script>
 
 <style lang="scss" module>

packages/editor-ui/src/components/PageContentWrapper.vue

@@ -1,35 +0,0 @@
-<template>
-	<div class="wrapper">
-		<div class="scroll">
-			<div class="content">
-				<slot></slot>
-			</div>
-		</div>
-	</div>
-</template>
-
-<script lang="ts">
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-	name: 'PageContentWrapper',
-});
-</script>
-
-<style scoped>
-.wrapper {
-	padding-top: 40px;
-	position: absolute;
-	width: 100%;
-	height: calc(100% - 40px);
-}
-.scroll {
-	overflow-y: auto;
-	width: 100%;
-	height: 100%;
-}
-.content {
-	padding: 1em;
-	height: 100%;
-}
-</style>

packages/editor-ui/src/components/ParameterInput.vue

@@ -119,7 +119,7 @@
 
 				<TextEdit
 					:dialog-visible="textEditDialogVisible"
-					:model-value="modelValue"
+					:model-value="`${modelValue}`"
 					:parameter="parameter"
 					:path="path"
 					:is-read-only="isReadOnly"

packages/editor-ui/src/components/ShortenName.vue

@@ -4,24 +4,24 @@
 	</span>
 </template>
 
-<script lang="ts">
+<script setup lang="ts">
-import { defineComponent } from 'vue';
+import { computed } from 'vue';
 import { shorten } from '@/utils/typesUtils';
 
 const DEFAULT_WORKFLOW_NAME_LIMIT = 25;
 const WORKFLOW_NAME_END_COUNT_TO_KEEP = 4;
 
-export default defineComponent({
+interface Props {
-	name: 'ShortenName',
+	name: string;
-	props: ['name', 'limit', 'testId'],
+	testId: string;
-	computed: {
+	limit?: number;
-		shortenedName(): string {
+}
-			return shorten(
+
-				this.name,
+const props = withDefaults(defineProps<Props>(), {
-				this.limit || DEFAULT_WORKFLOW_NAME_LIMIT,
+	limit: DEFAULT_WORKFLOW_NAME_LIMIT,
-				WORKFLOW_NAME_END_COUNT_TO_KEEP,
-			);
-		},
-	},
 });
+
+const shortenedName = computed(() =>
+	shorten(props.name, props.limit, WORKFLOW_NAME_END_COUNT_TO_KEEP),
+);
 </script>

packages/editor-ui/src/components/TagsManager/NoTagsView.vue

@@ -17,14 +17,6 @@
 	</div>
 </template>
 
-<script lang="ts">
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-	name: 'NoTagsView',
-});
-</script>
-
 <style lang="scss" module>
 $--footer-spacing: 45px;
 

packages/editor-ui/src/components/TagsManager/TagsView/TagsTableHeader.vue

@@ -27,33 +27,35 @@
 	</el-row>
 </template>
 
-<script lang="ts">
+<script setup lang="ts">
-import { defineComponent } from 'vue';
+import { ref } from 'vue';
 import { MAX_TAG_NAME_LENGTH } from '@/constants';
 
-export default defineComponent({
+withDefaults(
-	props: {
+	defineProps<{
-		disabled: {
+		disabled: boolean;
-			default: false,
+		search: string;
+	}>(),
+	{
+		disabled: false,
+		search: '',
 	},
-		search: {
+);
-			default: '',
+
-		},
+const emit = defineEmits<{
-	},
+	searchChange: [value: string];
-	data() {
+	createEnable: [];
-		return {
+}>();
-			maxLength: MAX_TAG_NAME_LENGTH,
+
+const maxLength = ref(MAX_TAG_NAME_LENGTH);
+
+const onAddNew = () => {
+	emit('createEnable');
+};
+
+const onSearchChange = (search: string) => {
+	emit('searchChange', search);
 };
-	},
-	methods: {
-		onAddNew() {
-			this.$emit('createEnable');
-		},
-		onSearchChange(search: string) {
-			this.$emit('searchChange', search);
-		},
-	},
-});
 </script>
 
 <style lang="scss" scoped>

packages/editor-ui/src/components/TemplateDetailsBlock.vue

@@ -9,17 +9,10 @@
 	</div>
 </template>
 
-<script lang="ts">
+<script lang="ts" setup>
-import { defineComponent } from 'vue';
+defineProps<{
-
+	title: string;
-export default defineComponent({
+}>();
-	name: 'TemplateDetailsBlock',
-	props: {
-		title: {
-			type: String,
-		},
-	},
-});
 </script>
 
 <style lang="scss" module>

packages/editor-ui/src/components/TextEdit.vue

@@ -11,7 +11,7 @@
 		>
 			<div class="ignore-key-press">
 				<n8n-input-label :label="$locale.nodeText().inputLabelDisplayName(parameter, path)">
-					<div @keydown.stop @keydown.esc="onKeyDownEsc()">
+					<div @keydown.stop @keydown.esc="onKeyDownEsc">
 						<n8n-input
 							ref="inputField"
 							v-model="tempValue"
@@ -28,49 +28,60 @@
 	</div>
 </template>
 
-<script lang="ts">
+<script setup lang="ts">
-import { nextTick, defineComponent } from 'vue';
+import { ref, watch, onMounted, nextTick } from 'vue';
+import type { INodeProperties } from 'n8n-workflow';
 
-export default defineComponent({
+const props = defineProps<{
-	name: 'TextEdit',
+	dialogVisible: boolean;
-	props: ['dialogVisible', 'parameter', 'path', 'modelValue', 'isReadOnly'],
+	parameter: INodeProperties;
-	data() {
+	path: string;
-		return {
+	modelValue: string;
-			tempValue: '', // el-input does not seem to work without v-model so add one
+	isReadOnly: boolean;
-		};
+}>();
-	},
+
-	watch: {
+const emit = defineEmits<{
-		async dialogVisible() {
+	'update:modelValue': [value: string];
-			if (this.dialogVisible === true) {
+	closeDialog: [];
+}>();
+
+const inputField = ref<HTMLInputElement | null>(null);
+const tempValue = ref('');
+
+watch(
+	() => props.dialogVisible,
+	async (newValue) => {
+		if (newValue) {
 			await nextTick();
-				(this.$refs.inputField as HTMLInputElement).focus();
+			inputField.value?.focus();
 		}
 	},
-		modelValue(value: string) {
+);
-			this.tempValue = value;
-		},
-	},
-	mounted() {
-		this.tempValue = this.modelValue as string;
-	},
-	methods: {
-		valueChanged(value: string) {
-			this.$emit('update:modelValue', value);
-		},
 
-		onKeyDownEsc() {
+watch(
+	() => props.modelValue,
+	(value: string) => {
+		tempValue.value = value;
+	},
+);
+
+onMounted(() => {
+	tempValue.value = props.modelValue;
+});
+
+const valueChanged = (value: string) => {
+	emit('update:modelValue', value);
+};
+
+const onKeyDownEsc = () => {
 	// Resetting input value when closing the dialog, required when closing it using the `Esc` key
-			this.tempValue = this.modelValue;
+	tempValue.value = props.modelValue;
+	closeDialog();
+};
 
-			this.closeDialog();
+const closeDialog = () => {
-		},
-
-		closeDialog() {
 	// Handle the close externally as the visible parameter is an external prop
 	// and is so not allowed to be changed here.
-			this.$emit('closeDialog');
+	emit('closeDialog');
-			return false;
+};
-		},
-	},
-});
 </script>

packages/editor-ui/src/components/TitledList.vue

@@ -7,22 +7,11 @@
 	</div>
 </template>
 
-<script lang="ts">
+<script lang="ts" setup>
-import { type PropType, defineComponent } from 'vue';
+defineProps<{
-
+	title: string;
-export default defineComponent({
+	items: string[];
-	name: 'TitledList',
+}>();
-	props: {
-		title: {
-			type: String,
-			required: true,
-		},
-		items: {
-			type: Array as PropType<string[]>,
-			default: () => [],
-		},
-	},
-});
 </script>
 <style lang="scss" scoped>
 .titled-list {

packages/editor-ui/src/components/transitions/SlideTransition.vue

@@ -4,14 +4,6 @@
 	</transition>
 </template>
 
-<script lang="ts">
-import { defineComponent } from 'vue';
-
-export default defineComponent({
-	name: 'SlideTransition',
-});
-</script>
-
 <style lang="scss" scoped>
 .slide-leave-active,
 .slide-enter-active {