From c70969da2bcabeb33394073a69ccef208311461b Mon Sep 17 00:00:00 2001 From: Ria Scholz <123465523+riascho@users.noreply.github.com> Date: Tue, 8 Oct 2024 14:22:39 +0200 Subject: [PATCH] fix(NASA Node): Astronomy-Picture-Of-The-Day fails when it's YouTube video (#11046) Co-authored-by: Jonathan Bennetts --- packages/nodes-base/nodes/Nasa/Nasa.node.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/nodes-base/nodes/Nasa/Nasa.node.ts b/packages/nodes-base/nodes/Nasa/Nasa.node.ts index b291680c59..7088465009 100644 --- a/packages/nodes-base/nodes/Nasa/Nasa.node.ts +++ b/packages/nodes-base/nodes/Nasa/Nasa.node.ts @@ -1069,7 +1069,7 @@ export class Nasa implements INodeType { if (resource === 'astronomyPictureOfTheDay') { download = this.getNodeParameter('download', 0); - if (download) { + if (download && responseData?.media_type === 'image') { const binaryProperty = this.getNodeParameter('binaryPropertyName', i); const data = await nasaApiRequest.call( @@ -1130,7 +1130,12 @@ export class Nasa implements INodeType { if (resource === 'earthImagery' && operation === 'get') { return [items]; - } else if (resource === 'astronomyPictureOfTheDay' && operation === 'get' && download) { + } else if ( + resource === 'astronomyPictureOfTheDay' && + operation === 'get' && + download && + responseData?.media_type === 'image' + ) { return [items]; } else { return [returnData];