From c7ee79aff86959219ea70265d9668173eced0044 Mon Sep 17 00:00:00 2001 From: Eugene Molodkin Date: Thu, 9 Jan 2025 13:39:16 +0100 Subject: [PATCH] wip: fix tests --- .../__tests__/test-runner.service.ee.test.ts | 32 +++++++++++++------ 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/packages/cli/src/evaluation.ee/test-runner/__tests__/test-runner.service.ee.test.ts b/packages/cli/src/evaluation.ee/test-runner/__tests__/test-runner.service.ee.test.ts index cc3c3bc33b..5d8fe3fe10 100644 --- a/packages/cli/src/evaluation.ee/test-runner/__tests__/test-runner.service.ee.test.ts +++ b/packages/cli/src/evaluation.ee/test-runner/__tests__/test-runner.service.ee.test.ts @@ -19,7 +19,7 @@ import type { WorkflowRepository } from '@/databases/repositories/workflow.repos import { LoadNodesAndCredentials } from '@/load-nodes-and-credentials'; import { NodeTypes } from '@/node-types'; import type { WorkflowRunner } from '@/workflow-runner'; -import { mockInstance } from '@test/mocking'; +import { mockInstance, mockLogger } from '@test/mocking'; import { mockNodeTypesData } from '@test-integration/utils/node-types-data'; import { TestRunnerService } from '../test-runner.service.ee'; @@ -129,6 +129,9 @@ function mockEvaluationExecutionData(metrics: Record) { }); } +const errorReporter = mock(); +const logger = mockLogger(); + describe('TestRunnerService', () => { const executionRepository = mock(); const workflowRepository = mock(); @@ -176,6 +179,7 @@ describe('TestRunnerService', () => { test('should create an instance of TestRunnerService', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -183,7 +187,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); expect(testRunnerService).toBeInstanceOf(TestRunnerService); @@ -191,6 +195,7 @@ describe('TestRunnerService', () => { test('should create and run test cases from past executions', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -198,7 +203,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); workflowRepository.findById.calledWith('workflow-under-test-id').mockResolvedValueOnce({ @@ -229,6 +234,7 @@ describe('TestRunnerService', () => { test('should run both workflow under test and evaluation workflow', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -236,7 +242,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); workflowRepository.findById.calledWith('workflow-under-test-id').mockResolvedValueOnce({ @@ -330,6 +336,7 @@ describe('TestRunnerService', () => { test('should properly count passed and failed executions', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -337,7 +344,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); workflowRepository.findById.calledWith('workflow-under-test-id').mockResolvedValueOnce({ @@ -388,6 +395,7 @@ describe('TestRunnerService', () => { test('should properly count failed test executions', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -395,7 +403,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); workflowRepository.findById.calledWith('workflow-under-test-id').mockResolvedValueOnce({ @@ -442,6 +450,7 @@ describe('TestRunnerService', () => { test('should properly count failed evaluations', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -449,7 +458,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); workflowRepository.findById.calledWith('workflow-under-test-id').mockResolvedValueOnce({ @@ -500,6 +509,7 @@ describe('TestRunnerService', () => { test('should specify correct start nodes when running workflow under test', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -507,7 +517,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); workflowRepository.findById.calledWith('workflow-under-test-id').mockResolvedValueOnce({ @@ -574,6 +584,7 @@ describe('TestRunnerService', () => { test('should properly choose trigger and start nodes', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -581,7 +592,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); const startNodesData = (testRunnerService as any).getStartNodesData( @@ -599,6 +610,7 @@ describe('TestRunnerService', () => { test('should properly choose trigger and start nodes 2', async () => { const testRunnerService = new TestRunnerService( + logger, workflowRepository, workflowRunner, executionRepository, @@ -606,7 +618,7 @@ describe('TestRunnerService', () => { testRunRepository, testMetricRepository, mockNodeTypes, - mock(), + errorReporter, ); const startNodesData = (testRunnerService as any).getStartNodesData(