mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(core): Route /rest/workflows/new correctly (no-changelog) (#6572)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-06-30 08:51:39 +02:00 committed by कारतोफ्फेलस्क्रिप्ट™
parent c2b9d5ac50
commit c906e7391b
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/cli/src/workflows/workflows.controller.ee.ts
View file

@ -87,6 +87,7 @@ EEWorkflowController.put(
EEWorkflowController.get( EEWorkflowController.get(
'/:id(\\w+)', '/:id(\\w+)',
(req, res, next) => (req.params.id === 'new' ? next('router') : next()), // skip ee router and use free one for naming
ResponseHelper.send(async (req: WorkflowRequest.Get) => { ResponseHelper.send(async (req: WorkflowRequest.Get) => {
const { id: workflowId } = req.params; const { id: workflowId } = req.params;

17
packages/cli/test/integration/workflows.controller.ee.test.ts
View file

@ -196,6 +196,23 @@ describe('GET /workflows', () => {
}); });
}); });
describe('GET /workflows/new', () => {
[true, false].forEach((sharingEnabled) => {
test(`should return an auto-incremented name, even when sharing is ${
sharingEnabled ? 'enabled' : 'disabled'
}`, async () => {
sharingSpy.mockReturnValueOnce(sharingEnabled);
await createWorkflow({ name: 'My workflow' }, owner);
await createWorkflow({ name: 'My workflow 7' }, owner);
const response = await authOwnerAgent.get('/workflows/new');
expect(response.statusCode).toBe(200);
expect(response.body.data.name).toEqual('My workflow 8');
});
});
});
describe('GET /workflows/:id', () => { describe('GET /workflows/:id', () => {
test('GET should fail with invalid id due to route rule', async () => { test('GET should fail with invalid id due to route rule', async () => {
const response = await authOwnerAgent.get('/workflows/potatoes'); const response = await authOwnerAgent.get('/workflows/potatoes');