mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-12 05:17:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Handle drag-n-dropping from other nodes in assignment component (#8661)

Browse source
This commit is contained in:
Elias Meire 2024-02-20 11:21:10 +01:00 committed by GitHub
parent 3279762221
commit c943a51a28
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/editor-ui/src/components/AssignmentCollection/__tests__/utils.test.ts Normal file
View file

@ -0,0 +1,15 @@
import { nameFromExpression } from '../utils';
describe('AssignmentCollection > utils', () => {
describe('nameFromExpression', () => {
test('should extract assignment name from previous node', () => {
expect(nameFromExpression('{{ $json.foo.bar }}')).toBe('foo.bar');
});
test('should extract assignment name from another node', () => {
expect(nameFromExpression("{{ $('Node's \"Name\" (copy)').item.json.foo.bar }}")).toBe(
'foo.bar',
);
});
});
});

5
packages/editor-ui/src/components/AssignmentCollection/utils.ts
View file

@ -4,7 +4,10 @@ import { resolveParameter } from '@/composables/useWorkflowHelpers';
import { v4 as uuid } from 'uuid';
export function nameFromExpression(expression: string): string {
return expression.replace(/^{{\s*|\s*}}$/g, '').replace('$json.', '');
return expression
.replace(/^{{\s*|\s*}}$/g, '')
.replace('$json.', '')
.replace(/^\$\(.*\)(\.item\.json)?\.(.*)/, '$2');
}
export function inferAssignmentType(value: unknown): string {