From c9e158e45848ee94b04f49694a552f9f272a97dd Mon Sep 17 00:00:00 2001 From: Jan Oberhauser Date: Fri, 13 Jan 2023 09:22:37 -0600 Subject: [PATCH] fix(core): Throw error in UI on expression referencing missing node but do not fail execution (#5158) fix(core): Throw error in UI on expression referencing missing node but do not fail execution --- packages/workflow/src/WorkflowDataProxy.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/workflow/src/WorkflowDataProxy.ts b/packages/workflow/src/WorkflowDataProxy.ts index 6477244e84..3cc2c280a7 100644 --- a/packages/workflow/src/WorkflowDataProxy.ts +++ b/packages/workflow/src/WorkflowDataProxy.ts @@ -575,14 +575,14 @@ export class WorkflowDataProxy { get(target, name, receiver) { const nodeName = name.toString(); - // TODO: re-enable this for v1.0.0 release - // if (that.workflow.getNode(nodeName) === null) { - // throw new ExpressionError(`"${nodeName}" node doesn't exist`, { - // runIndex: that.runIndex, - // itemIndex: that.itemIndex, - // failExecution: true, - // }); - // } + if (that.workflow.getNode(nodeName) === null) { + throw new ExpressionError(`"${nodeName}" node doesn't exist`, { + runIndex: that.runIndex, + itemIndex: that.itemIndex, + // TODO: re-enable this for v1.0.0 release + // failExecution: true, + }); + } return that.nodeDataGetter(nodeName); },