From ca0f0df63586adb557b7bce9414e4736381208e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= <ivov.src@gmail.com>
Date: Mon, 2 May 2022 10:34:59 +0200
Subject: [PATCH] :zap: Use prop to set component order

---
 packages/editor-ui/src/components/NodeSettings.vue       | 6 ++++++
 packages/editor-ui/src/components/ParameterInputList.vue | 8 ++------
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/packages/editor-ui/src/components/NodeSettings.vue b/packages/editor-ui/src/components/NodeSettings.vue
index d45131acfc..d27a50551e 100644
--- a/packages/editor-ui/src/components/NodeSettings.vue
+++ b/packages/editor-ui/src/components/NodeSettings.vue
@@ -31,6 +31,7 @@
 					:parameters="parametersNoneSetting"
 					:hideDelete="true"
 					:nodeValues="nodeValues" path="parameters" @valueChanged="valueChanged"
+					:showCredentialsAfter="showCredentialsAfter"
 				>
 					<node-credentials
 						:node="node"
@@ -81,6 +82,8 @@ import { nodeHelpers } from '@/components/mixins/nodeHelpers';
 import mixins from 'vue-typed-mixins';
 import NodeExecuteButton from './NodeExecuteButton.vue';
 
+import { HTTP_REQUEST_NODE_TYPE } from '@/constants';
+
 export default mixins(
 	externalHooks,
 	genericHelpers,
@@ -158,6 +161,9 @@ export default mixins(
 
 				return this.nodeType.properties;
 			},
+			showCredentialsAfter (): boolean {
+				return this.node.type === HTTP_REQUEST_NODE_TYPE && this.node.typeVersion === 2;
+			},
 		},
 		props: {
 			eventBus: {
diff --git a/packages/editor-ui/src/components/ParameterInputList.vue b/packages/editor-ui/src/components/ParameterInputList.vue
index a6658344da..40531b924b 100644
--- a/packages/editor-ui/src/components/ParameterInputList.vue
+++ b/packages/editor-ui/src/components/ParameterInputList.vue
@@ -1,5 +1,5 @@
 <template>
-	<div class="parameter-input-list-wrapper" :class="{ 'has-reordered-credentials-input': hasReorderedCredentialsInput }">
+	<div class="parameter-input-list-wrapper" :class="{ 'has-reordered-credentials-input': showCredentialsAfter }">
 		<slot />
 		<div v-for="parameter in filteredParameters" :key="parameter.name" :class="{indent}">
 			<div
@@ -118,6 +118,7 @@ export default mixins(
 			'path', // string
 			'hideDelete', // boolean
 			'indent',
+			'showCredentialsAfter', // boolean
 		],
 		computed: {
 			filteredParameters (): INodeProperties[] {
@@ -126,11 +127,6 @@ export default mixins(
 			filteredParameterNames (): string[] {
 				return this.filteredParameters.map(parameter => parameter.name);
 			},
-			hasReorderedCredentialsInput(): boolean {
-				const node: INode = this.$store.getters.activeNode;
-
-				return ["n8n-nodes-base.httpRequest"].includes(node.type);
-			},
 			node (): INodeUi {
 				return this.$store.getters.activeNode;
 			},