mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Removing redundancies in Woo-Commerce node. (#596)

Browse source 
* Iterating additionalFields given instead of hard coding the interface to match them when creating a product

* Removed redundancy for product creation/update and order create.

Co-authored-by: Omar Ajoue <krynble@gmail.com>
This commit is contained in:
Jacob Burrell 2021-08-04 09:06:15 -07:00 committed by GitHub
parent ce354ed0cf
commit caa6a3d234
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 22 additions and 258 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/nodes-base/nodes/WooCommerce/GenericFunctions.ts
View file

@ -149,6 +149,12 @@ export function toSnakeCase(data:
} }
} }
export function setFields(fieldsToSet: IDataObject, body: any) {
for(let fields in fieldsToSet) {
body[snakeCase(fields.toString())] = fieldsToSet[fields]
}
}
export function adjustMetadata(fields: IDataObject & Metadata) { export function adjustMetadata(fields: IDataObject & Metadata) {
if (!fields.meta_data) return fields; if (!fields.meta_data) return fields;

1
packages/nodes-base/nodes/WooCommerce/OrderInterface.ts
View file

@ -46,6 +46,7 @@ export interface ICouponLine {
} }
export interface IOrder { export interface IOrder {
[index: string]: any
billing?: IAddress; billing?: IAddress;
coupon_lines?: ICouponLine[]; coupon_lines?: ICouponLine[];
currency?: string; currency?: string;

39
packages/nodes-base/nodes/WooCommerce/ProductInterface.ts
View file

@ -13,42 +13,5 @@ export interface IImage {
} }
export interface IProduct { export interface IProduct {
backorders?: string; [index: string]: any
button_text?: string;
catalog_visibility?: string;
categories?: IDataObject[];
cross_sell_ids?: string[];
date_on_sale_from?: string;
date_on_sale_to?: string;
description?: string;
dimensions?: IDimension;
downloadable?: boolean;
external_url?: string;
featured?: boolean;
images?: IImage[];
manage_stock?: boolean;
menu_order?: number;
meta_data?: IDataObject[];
name?: string;
parent_id?: string;
price?: string;
purchase_note?: string;
regular_price?: string;
reviews_allowed?: boolean;
sale_price?: string;
shipping_class?: string;
short_description?: string;
sku?: string;
slug?: string;
sold_individually?: boolean;
status?: string;
stock_quantity?: number;
stock_status?: string;
tags?: IDataObject[];
tax_class?: string;
tax_status?: string;
type?: string;
upsell_ids?: string[];
virtual?: boolean;
weight?: string;
} }

234
packages/nodes-base/nodes/WooCommerce/WooCommerce.node.ts
View file

@ -15,6 +15,7 @@ import {
toSnakeCase, toSnakeCase,
woocommerceApiRequest, woocommerceApiRequest,
woocommerceApiRequestAllItems, woocommerceApiRequestAllItems,
setFields,
} from './GenericFunctions'; } from './GenericFunctions';
import { import {
productFields, productFields,
@ -249,105 +250,16 @@ export class WooCommerce implements INodeType {
if (operation === 'create') { if (operation === 'create') {
const name = this.getNodeParameter('name', i) as string; const name = this.getNodeParameter('name', i) as string;
const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject; const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject;
const body: IProduct = { let body: IProduct = {
name, name,
}; };
if (additionalFields.backorders) {
body.backorders = additionalFields.backorders as string; setFields(additionalFields, body)
}
if (additionalFields.buttonText) {
body.button_text = additionalFields.buttonText as string;
}
if (additionalFields.catalogVisibility) {
body.catalog_visibility = additionalFields.catalogVisibility as string;
}
if (additionalFields.categories) { if (additionalFields.categories) {
body.categories = (additionalFields.categories as string[]).map(category => ({ id: parseInt(category, 10) })) as unknown as IDataObject[]; body.categories = (additionalFields.categories as string[]).map(category => ({ id: parseInt(category, 10) })) as unknown as IDataObject[];
} }
if (additionalFields.crossSellIds) {
body.cross_sell_ids = (additionalFields.crossSellIds as string).split(',') as string[];
}
if (additionalFields.dateOnSaleFrom) {
body.date_on_sale_from = additionalFields.dateOnSaleFrom as string;
}
if (additionalFields.dateOnSaleTo) {
body.date_on_sale_to = additionalFields.dateOnSaleTo as string;
}
if (additionalFields.description) {
body.description = additionalFields.description as string;
}
if (additionalFields.downloadable) {
body.downloadable = additionalFields.downloadable as boolean;
}
if (additionalFields.externalUrl) {
body.external_url = additionalFields.externalUrl as string;
}
if (additionalFields.featured) {
body.featured = additionalFields.featured as boolean;
}
if (additionalFields.manageStock) {
body.manage_stock = additionalFields.manageStock as boolean;
}
if (additionalFields.parentId) {
body.parent_id = additionalFields.parentId as string;
}
if (additionalFields.purchaseNote) {
body.purchase_note = additionalFields.purchaseNote as string;
}
if (additionalFields.regularPrice) {
body.regular_price = additionalFields.regularPrice as string;
}
if (additionalFields.reviewsAllowed) {
body.reviews_allowed = additionalFields.reviewsAllowed as boolean;
}
if (additionalFields.salePrice) {
body.sale_price = additionalFields.salePrice as string;
}
if (additionalFields.shippingClass) {
body.shipping_class = additionalFields.shippingClass as string;
}
if (additionalFields.shortDescription) {
body.short_description = additionalFields.shortDescription as string;
}
if (additionalFields.sku) {
body.sku = additionalFields.sku as string;
}
if (additionalFields.slug) {
body.slug = additionalFields.slug as string;
}
if (additionalFields.soldIndividually) {
body.sold_individually = additionalFields.soldIndividually as boolean;
}
if (additionalFields.status) {
body.status = additionalFields.status as string;
}
if (additionalFields.stockQuantity) {
body.stock_quantity = additionalFields.stockQuantity as number;
}
if (additionalFields.stockStatus) {
body.stock_status = additionalFields.stockStatus as string;
}
if (additionalFields.tags) {
body.tags = (additionalFields.tags as string[]).map(tag => ({ 'id': parseInt(tag, 10) })) as unknown as IDataObject[];
}
if (additionalFields.taxClass) {
body.tax_class = additionalFields.taxClass as string;
}
if (additionalFields.taxStatus) {
body.tax_status = additionalFields.taxStatus as string;
}
if (additionalFields.type) {
body.type = additionalFields.type as string;
}
if (additionalFields.upsellIds) {
body.upsell_ids = (additionalFields.upsellIds as string).split(',') as string[];
}
if (additionalFields.virtual) {
body.virtual = additionalFields.virtual as boolean;
}
if (additionalFields.weight) {
body.weight = additionalFields.weight as string;
}
const images = (this.getNodeParameter('imagesUi', i) as IDataObject).imagesValues as IImage[]; const images = (this.getNodeParameter('imagesUi', i) as IDataObject).imagesValues as IImage[];
if (images) { if (images) {
body.images = images; body.images = images;
@ -367,105 +279,9 @@ export class WooCommerce implements INodeType {
const productId = this.getNodeParameter('productId', i) as string; const productId = this.getNodeParameter('productId', i) as string;
const updateFields = this.getNodeParameter('updateFields', i) as IDataObject; const updateFields = this.getNodeParameter('updateFields', i) as IDataObject;
const body: IProduct = {}; const body: IProduct = {};
if (updateFields.name) {
body.name = updateFields.name as string; setFields(updateFields, body)
}
if (updateFields.backorders) {
body.backorders = updateFields.backorders as string;
}
if (updateFields.buttonText) {
body.button_text = updateFields.buttonText as string;
}
if (updateFields.catalogVisibility) {
body.catalog_visibility = updateFields.catalogVisibility as string;
}
if (updateFields.categories) {
body.categories = (updateFields.categories as string[]).map(category => ({ id: parseInt(category, 10) })) as unknown as IDataObject[];
}
if (updateFields.crossSellIds) {
body.cross_sell_ids = (updateFields.crossSellIds as string).split(',') as string[];
}
if (updateFields.dateOnSaleFrom) {
body.date_on_sale_from = updateFields.dateOnSaleFrom as string;
}
if (updateFields.dateOnSaleTo) {
body.date_on_sale_to = updateFields.dateOnSaleTo as string;
}
if (updateFields.description) {
body.description = updateFields.description as string;
}
if (updateFields.downloadable) {
body.downloadable = updateFields.downloadable as boolean;
}
if (updateFields.externalUrl) {
body.external_url = updateFields.externalUrl as string;
}
if (updateFields.featured) {
body.featured = updateFields.featured as boolean;
}
if (updateFields.manageStock) {
body.manage_stock = updateFields.manageStock as boolean;
}
if (updateFields.parentId) {
body.parent_id = updateFields.parentId as string;
}
if (updateFields.purchaseNote) {
body.purchase_note = updateFields.purchaseNote as string;
}
if (updateFields.regularPrice) {
body.regular_price = updateFields.regularPrice as string;
}
if (updateFields.reviewsAllowed) {
body.reviews_allowed = updateFields.reviewsAllowed as boolean;
}
if (updateFields.salePrice) {
body.sale_price = updateFields.salePrice as string;
}
if (updateFields.shippingClass) {
body.shipping_class = updateFields.shippingClass as string;
}
if (updateFields.shortDescription) {
body.short_description = updateFields.shortDescription as string;
}
if (updateFields.sku) {
body.sku = updateFields.sku as string;
}
if (updateFields.slug) {
body.slug = updateFields.slug as string;
}
if (updateFields.soldIndividually) {
body.sold_individually = updateFields.soldIndividually as boolean;
}
if (updateFields.status) {
body.status = updateFields.status as string;
}
if (updateFields.stockQuantity) {
body.stock_quantity = updateFields.stockQuantity as number;
}
if (updateFields.stockStatus) {
body.stock_status = updateFields.stockStatus as string;
}
if (updateFields.tags) {
body.tags = (updateFields.tags as string[]).map(tag => ({ id: parseInt(tag, 10) })) as unknown as IDataObject[];
}
if (updateFields.taxClass) {
body.tax_class = updateFields.taxClass as string;
}
if (updateFields.taxStatus) {
body.tax_status = updateFields.taxStatus as string;
}
if (updateFields.type) {
body.type = updateFields.type as string;
}
if (updateFields.upsellIds) {
body.upsell_ids = (updateFields.upsellIds as string).split(',') as string[];
}
if (updateFields.virtual) {
body.virtual = updateFields.virtual as boolean;
}
if (updateFields.weight) {
body.weight = updateFields.weight as string;
}
const images = (this.getNodeParameter('imagesUi', i) as IDataObject).imagesValues as IImage[]; const images = (this.getNodeParameter('imagesUi', i) as IDataObject).imagesValues as IImage[];
if (images) { if (images) {
body.images = images; body.images = images;
@ -558,33 +374,9 @@ export class WooCommerce implements INodeType {
if (operation === 'create') { if (operation === 'create') {
const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject; const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject;
const body: IOrder = {}; const body: IOrder = {};
if (additionalFields.currency) {
body.currency = additionalFields.currency as string; setFields(additionalFields, body)
}
if (additionalFields.customerId) {
body.customer_id = parseInt(additionalFields.customerId as string, 10);
}
if (additionalFields.customerNote) {
body.customer_note = additionalFields.customerNote as string;
}
if (additionalFields.parentId) {
body.parent_id = parseInt(additionalFields.parentId as string, 10);
}
if (additionalFields.paymentMethodId) {
body.payment_method = additionalFields.paymentMethodId as string;
}
if (additionalFields.paymentMethodTitle) {
body.payment_method_title = additionalFields.paymentMethodTitle as string;
}
if (additionalFields.setPaid) {
body.set_paid = additionalFields.setPaid as boolean;
}
if (additionalFields.status) {
body.status = additionalFields.status as string;
}
if (additionalFields.transactionID) {
body.transaction_id = additionalFields.transactionID as string;
}
const billing = (this.getNodeParameter('billingUi', i) as IDataObject).billingValues as IAddress; const billing = (this.getNodeParameter('billingUi', i) as IDataObject).billingValues as IAddress;
if (billing !== undefined) { if (billing !== undefined) {
body.billing = billing; body.billing = billing;
@ -631,6 +423,7 @@ export class WooCommerce implements INodeType {
const orderId = this.getNodeParameter('orderId', i) as string; const orderId = this.getNodeParameter('orderId', i) as string;
const updateFields = this.getNodeParameter('updateFields', i) as IDataObject; const updateFields = this.getNodeParameter('updateFields', i) as IDataObject;
const body: IOrder = {}; const body: IOrder = {};
if (updateFields.currency) { if (updateFields.currency) {
body.currency = updateFields.currency as string; body.currency = updateFields.currency as string;
} }
@ -694,6 +487,7 @@ export class WooCommerce implements INodeType {
setMetadata(shippingLines); setMetadata(shippingLines);
toSnakeCase(shippingLines); toSnakeCase(shippingLines);
} }
responseData = await woocommerceApiRequest.call(this, 'PUT', `/orders/${orderId}`, body); responseData = await woocommerceApiRequest.call(this, 'PUT', `/orders/${orderId}`, body);
} }
//https://woocommerce.github.io/woocommerce-rest-api-docs/#retrieve-an-order //https://woocommerce.github.io/woocommerce-rest-api-docs/#retrieve-an-order