mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Set Node): Field not excluded if dot notation disabled and field was set by using drag-and-drop from ui (#8233)

Browse source 
## Summary
Sanitize fields when dot notation disabled

![image](https://github.com/n8n-io/n8n/assets/88898367/5056bc8d-279e-4bc2-8689-4858fc25474d)

## Related tickets and issues

https://community.n8n.io/t/edit-fields-set-new-set-node-cannot-delete-field-with-space-or-non-latin-character-when-support-dot-notation-is-off/31989

https://linear.app/n8n/issue/NODE-883/set-edit-fields-node-spaces-in-field-names-break-fields-to-exclude
This commit is contained in:
Michael Kret 2024-01-05 11:15:33 +02:00 committed by GitHub
parent 43e8e5e540
commit cda49a4747
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/nodes-base/nodes/Set/v2/helpers/utils.ts
View file

@ -35,15 +35,28 @@ const configureFieldHelper = (dotNotation?: boolean) => {
},
};
} else {
const sanitazeKey = (item: IDataObject, key: string) => {
if (item[key] !== undefined) {
return key;
}
if (key.startsWith("['") && key.endsWith("']")) {
key = key.slice(2, -2);
if (item[key] !== undefined) {
return key;
}
}
return key;
};
return {
set: (item: IDataObject, key: string, value: IDataObject) => {
item[key] = value;
item[sanitazeKey(item, key)] = value;
},
get: (item: IDataObject, key: string) => {
return item[key];
return item[sanitazeKey(item, key)];
},
unset: (item: IDataObject, key: string) => {
delete item[key];
delete item[sanitazeKey(item, key)];
},
};
}