mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-26 05:04:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(XML Node): Fix issue with not returning valid data (#6565)

Browse source
This commit is contained in:
Jan Oberhauser 2023-06-29 15:30:39 +02:00 committed by GitHub
parent b17b4582a0
commit cdd215f642
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 136 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/nodes-base/nodes/Xml/Xml.node.ts
View file

@ -5,7 +5,7 @@ import type {
INodeType, INodeType,
INodeTypeDescription, INodeTypeDescription,
} from 'n8n-workflow'; } from 'n8n-workflow';
import { NodeOperationError } from 'n8n-workflow'; import { NodeOperationError, deepCopy } from 'n8n-workflow';
export class Xml implements INodeType { export class Xml implements INodeType {
description: INodeTypeDescription = { description: INodeTypeDescription = {
@ -249,7 +249,7 @@ export class Xml implements INodeType {
} }
const json = await parser.parseStringPromise(item.json[dataPropertyName] as string); const json = await parser.parseStringPromise(item.json[dataPropertyName] as string);
returnData.push({ json }); returnData.push({ json: deepCopy(json) });
} else if (mode === 'jsonToxml') { } else if (mode === 'jsonToxml') {
const builder = new Builder(options); const builder = new Builder(options);

134
packages/nodes-base/nodes/Xml/test/node/workflow.xml-valid-data.json Normal file
View file

@ -0,0 +1,134 @@
{
"name": "My workflow",
"nodes": [
{
"parameters": {},
"id": "7f04c09e-5a60-4a0c-a336-ef38e4732452",
"name": "When clicking \"Execute Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [860, 380]
},
{
"parameters": {
"jsCode": "return [\n {\n json: {\n a: {\n b: {\n c: 1\n }\n }\n }\n }\n];\n"
},
"id": "be80ce82-d312-460d-ac79-05c0626845ad",
"name": "Code",
"type": "n8n-nodes-base.code",
"typeVersion": 1,
"position": [1080, 380]
},
{
"parameters": {
"mode": "jsonToxml",
"options": {}
},
"id": "c352655b-e0dc-4f7c-a63a-ff1bc5f1909f",
"name": "XML",
"type": "n8n-nodes-base.xml",
"typeVersion": 1,
"position": [1300, 380]
},
{
"parameters": {
"options": {}
},
"id": "21547e44-133e-4c3b-a601-0cffba1daf9b",
"name": "XML1",
"type": "n8n-nodes-base.xml",
"typeVersion": 1,
"position": [1500, 380]
},
{
"parameters": {
"values": {
"string": [
{
"name": "new",
"value": "={{ $json.a }}"
}
]
},
"options": {}
},
"id": "632dee22-10d1-424d-b1d2-673b95b32943",
"name": "Set",
"type": "n8n-nodes-base.set",
"typeVersion": 2,
"position": [1720, 380]
}
],
"pinData": {
"Set": [
{
"json": {
"a": {
"b": {
"c": "1"
}
},
"new": {
"b": {
"c": "1"
}
}
}
}
]
},
"connections": {
"When clicking \"Execute Workflow\"": {
"main": [
[
{
"node": "Code",
"type": "main",
"index": 0
}
]
]
},
"Code": {
"main": [
[
{
"node": "XML",
"type": "main",
"index": 0
}
]
]
},
"XML": {
"main": [
[
{
"node": "XML1",
"type": "main",
"index": 0
}
]
]
},
"XML1": {
"main": [
[
{
"node": "Set",
"type": "main",
"index": 0
}
]
]
}
},
"active": false,
"settings": {},
"versionId": "14c1d4b8-3546-4692-8e8a-44c244c79bcc",
"id": "0G78Fh2FTnM46kuR",
"meta": {
"instanceId": "021d3c82ba2d3bc090cbf4fc81c9312668bcc34297e022bb3438c5c88a43a5ff"
},
"tags": []
}