From cf563e567d3941710609f754c19f0a0d3e5d813f Mon Sep 17 00:00:00 2001
From: Mutasem <mutdmour@gmail.com>
Date: Wed, 6 Apr 2022 08:07:38 +0200
Subject: [PATCH] add trigger warning disabled

---
 .../editor-ui/src/components/DataDisplay.vue  | 26 ++++++++++++-------
 .../src/plugins/i18n/locales/en.json          |  1 +
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/packages/editor-ui/src/components/DataDisplay.vue b/packages/editor-ui/src/components/DataDisplay.vue
index 9e19dba252..0da6bf49db 100644
--- a/packages/editor-ui/src/components/DataDisplay.vue
+++ b/packages/editor-ui/src/components/DataDisplay.vue
@@ -6,12 +6,14 @@
 		custom-class="data-display-wrapper"
 		width="85%"
 		append-to-body
-		@opened="showDocumentHelp = true"
 	>
-		<div :class="$style.backToCanvas">
-			<n8n-icon icon="arrow-left" color="text-xlight" size="small" />
-			<n8n-text color="text-xlight" size="small">{{ $locale.baseText('node.backToCanvas') }}</n8n-text>
-		</div>
+		<n8n-tooltip placement="bottom-start" :disabled="!triggerWaitingWarningEnabled">
+			<div slot="content" :class="$style.triggerWarning">{{ $locale.baseText('node.backToCanvas.waitingForTriggerWarning') }}</div>
+			<div :class="$style.backToCanvas" @click="close">
+				<n8n-icon icon="arrow-left" color="text-xlight" size="small" />
+				<n8n-text color="text-xlight" size="small">{{ $locale.baseText('node.backToCanvas') }}</n8n-text>
+			</div>
+		</n8n-tooltip>
 
 		<div class="data-display" v-if="node" >
 			<NodeSettings :eventBus="settingsEventBus" @valueChanged="valueChanged" />
@@ -47,9 +49,8 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers).extend({
 	},
 	data () {
 		return {
-			basePath: this.$store.getters.getBaseUrl,
-			showDocumentHelp: false,
 			settingsEventBus: new Vue(),
+			triggerWaitingWarningEnabled: false,
 		};
 	},
 	computed: {
@@ -86,7 +87,7 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers).extend({
 		},
 		close () {
 			this.$externalHooks().run('dataDisplay.nodeEditingFinished');
-			this.showDocumentHelp = false;
+			this.triggerWaitingWarningEnabled = false;
 			this.$store.commit('setActiveNode', null);
 		},
 	},
@@ -130,10 +131,17 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers).extend({
 </style>
 
 <style lang="scss" module>
+.triggerWarning {
+	max-width: 180px;
+}
+
 .backToCanvas {
 	position: absolute;
 	top: -24px;
-	pointer-events: none;
+
+	&:hover {
+		cursor: pointer;
+	}
 
 	> * {
 		margin-right: var(--spacing-3xs);
diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json
index df140f516b..c3f780f9e4 100644
--- a/packages/editor-ui/src/plugins/i18n/locales/en.json
+++ b/packages/editor-ui/src/plugins/i18n/locales/en.json
@@ -1161,6 +1161,7 @@
 	"node.output.emptyInput": "This input item is empty. {name} will still execute when it recieves an empty item.",
 	"node.output.staleDataWarning": "Node parameters have changed. <br /> Execute node again to refresh output.",
 	"node.backToCanvas": "Back to canvas",
+	"node.backToCanvas.waitingForTriggerWarning": "Waiting for a Trigger node to execute. Close this view to see the Workflow Canvas.",
 	"openWorkflow.workflowImportError": "Could not import workflow",
 	"openWorkflow.workflowNotFoundError": "Could not find workflow",
 	"settings": "Settings",