mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Hide data pinning discoverability tooltip in execution view (#5145)

Browse source 
* fix(editor): remove unused prop

* fix(editor): Prevent data pinning discoverability tooltip displayed in executions view
This commit is contained in:
Csaba Tuncsik 2023-01-13 12:43:51 +01:00 committed by GitHub
parent 665eaef925
commit d10ca530cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/editor-ui/src/components/OutputPanel.vue
View file

@ -9,7 +9,6 @@
:isExecuting="isNodeRunning" :isExecuting="isNodeRunning"
:executingMessage="$locale.baseText('ndv.output.executing')" :executingMessage="$locale.baseText('ndv.output.executing')"
:sessionId="sessionId" :sessionId="sessionId"
:isReadOnly="isReadOnly"
:blockUI="blockUI" :blockUI="blockUI"
:isProductionExecutionPreview="isProductionExecutionPreview" :isProductionExecutionPreview="isProductionExecutionPreview"
paneType="output" paneType="output"

14
packages/editor-ui/src/components/RunData.vue
View file

@ -590,11 +590,8 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten
this.eventBus.$on('data-pinning-error', this.onDataPinningError); this.eventBus.$on('data-pinning-error', this.onDataPinningError);
this.eventBus.$on('data-unpinning', this.onDataUnpinning); this.eventBus.$on('data-unpinning', this.onDataUnpinning);
const hasSeenPinDataTooltip = localStorage.getItem(LOCAL_STORAGE_PIN_DATA_DISCOVERY_NDV_FLAG);
if (!hasSeenPinDataTooltip) {
this.showPinDataDiscoveryTooltip(this.jsonData); this.showPinDataDiscoveryTooltip(this.jsonData);
} }
}
this.ndvStore.setNDVBranchIndex({ this.ndvStore.setNDVBranchIndex({
pane: this.paneType as 'input' | 'output', pane: this.paneType as 'input' | 'output',
branchIndex: this.currentOutputIndex, branchIndex: this.currentOutputIndex,
@ -861,7 +858,12 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten
return; return;
} }
if (value && value.length > 0) { if (
value &&
value.length > 0 &&
!this.isReadOnly &&
!localStorage.getItem(LOCAL_STORAGE_PIN_DATA_DISCOVERY_NDV_FLAG)
) {
this.pinDataDiscoveryComplete(); this.pinDataDiscoveryComplete();
setTimeout(() => { setTimeout(() => {
@ -1290,11 +1292,7 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten
}, },
jsonData(value: IDataObject[]) { jsonData(value: IDataObject[]) {
this.refreshDataSize(); this.refreshDataSize();
const hasSeenPinDataTooltip = localStorage.getItem(LOCAL_STORAGE_PIN_DATA_DISCOVERY_NDV_FLAG);
if (!hasSeenPinDataTooltip) {
this.showPinDataDiscoveryTooltip(value); this.showPinDataDiscoveryTooltip(value);
}
}, },
binaryData(newData: IBinaryKeyData[], prevData: IBinaryKeyData[]) { binaryData(newData: IBinaryKeyData[], prevData: IBinaryKeyData[]) {
if (newData.length && !prevData.length && this.displayMode !== 'binary') { if (newData.length && !prevData.length && this.displayMode !== 'binary') {