mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(Metabase Node): Fix issue with question results not correctly being returned (#5665)

Browse source
This commit is contained in:
Jon 2023-03-14 17:47:37 +00:00 committed by GitHub
parent 8fe34f543e
commit d1e3c192ba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 27 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
packages/nodes-base/nodes/Metabase/QuestionsDescription.ts
View file

@ -1,10 +1,4 @@
import type {
IDataObject,
IExecuteSingleFunctions,
IN8nHttpFullResponse,
INodeExecutionData,
INodeProperties,
} from 'n8n-workflow';
import type { IDataObject, INodeProperties } from 'n8n-workflow';
import { jsonParse } from 'n8n-workflow';
export const questionsOperations: INodeProperties[] = [
@ -56,43 +50,38 @@ export const questionsOperations: INodeProperties[] = [
},
output: {
postReceive: [
// @ts-ignore
async function (
this: IExecuteSingleFunctions,
_items: INodeExecutionData[],
response: IN8nHttpFullResponse,
): Promise<INodeExecutionData[]> {
const items = _items;
const result: INodeExecutionData[] = [];
for (let i = 0; i < items.length; i++) {
const newItem: INodeExecutionData = {
json: items[i].json,
binary: {},
};
async function (this, items, responseData) {
const datatype = this.getNodeParameter('format') as string;
if (items[i].binary !== undefined && newItem.binary) {
Object.assign(newItem.binary, items[i].binary);
}
items[i] = newItem;
if (this.getNode().parameters.format === 'json') {
items[i].json = jsonParse<IDataObject[]>(items[i].json as unknown as string)[0];
console.log(items[i].json);
delete items[i].binary;
} else {
items[i].binary!.data = await this.helpers.prepareBinaryData(
response.body as Buffer,
if (datatype !== 'json') {
const binaryData = await this.helpers.prepareBinaryData(
responseData.body as Buffer,
'data',
response.headers['content-type'] as string,
responseData.headers['content-type'] as string,
);
// Transform items
items = items.map((item) => {
item.json = {};
item.binary = { ['data']: binaryData };
return item;
});
} else {
const results = jsonParse<IDataObject[]>(responseData.body as unknown as string);
items = results.map((result) => {
return {
json: {
...result,
},
};
});
}
result.push(items[i]);
}
return result;
return items;
},
],
},
},
action: 'Result Data a questions',
action: 'Get the results from a question',
},
],
default: 'getAll',