mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡ Reuse Github webhook if it exists already

Browse source
This commit is contained in:
Jan Oberhauser 2019-12-14 14:44:56 -06:00
parent 4ceeb9bbc0
commit d1eb102de7
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/nodes-base/nodes/Github/GithubTrigger.node.ts
View file

@ -352,12 +352,31 @@ export class GithubTrigger implements INodeType {
active: true, active: true,
}; };
const webhookData = this.getWorkflowStaticData('node');
let responseData; let responseData;
try { try {
responseData = await githubApiRequest.call(this, 'POST', endpoint, body); responseData = await githubApiRequest.call(this, 'POST', endpoint, body);
} catch (e) { } catch (e) {
if (e.message.includes('[422]:')) { if (e.message.includes('[422]:')) {
// Webhook exists already
// Get the data of the already registered webhook
responseData = await githubApiRequest.call(this, 'GET', endpoint, body);
for (const webhook of responseData as IDataObject[]) {
if ((webhook!.config! as IDataObject).url! === webhookUrl) {
// Webhook got found
if (JSON.stringify(webhook.events) === JSON.stringify(events)) {
// Webhook with same events exists already so no need to
// create it again simply save the webhook-id
webhookData.webhookId = webhook.id as string;
webhookData.webhookEvents = webhook.events as string[];
return true;
}
}
}
throw new Error('A webhook with the identical URL exists already. Please delete it manually on Github!'); throw new Error('A webhook with the identical URL exists already. Please delete it manually on Github!');
} }
@ -369,7 +388,6 @@ export class GithubTrigger implements INodeType {
throw new Error('Github webhook creation response did not contain the expected data.'); throw new Error('Github webhook creation response did not contain the expected data.');
} }
const webhookData = this.getWorkflowStaticData('node');
webhookData.webhookId = responseData.id as string; webhookData.webhookId = responseData.id as string;
webhookData.webhookEvents = responseData.events as string[]; webhookData.webhookEvents = responseData.events as string[];