From d24dbaf9e9f621b09468a1e6c42d88f9e536a5a3 Mon Sep 17 00:00:00 2001
From: Alex Grozav <alex@grozav.com>
Date: Tue, 18 Jul 2023 14:51:44 +0300
Subject: [PATCH] fix: fix workflow saving and grabber notch

---
 packages/editor-ui/src/components/CollectionCard.vue   |  7 +------
 .../src/components/MainHeader/WorkflowDetails.vue      |  4 +---
 packages/editor-ui/src/components/NodeDetailsView.vue  |  4 ++--
 packages/editor-ui/src/components/NodeSettings.vue     | 10 +++++-----
 packages/editor-ui/src/components/SaveButton.vue       |  1 -
 .../editor-ui/src/composables/useLoadingService.ts     |  1 +
 packages/editor-ui/src/mixins/workflowHelpers.ts       |  2 ++
 7 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/packages/editor-ui/src/components/CollectionCard.vue b/packages/editor-ui/src/components/CollectionCard.vue
index 2a0a62fa51..97fc3c450c 100644
--- a/packages/editor-ui/src/components/CollectionCard.vue
+++ b/packages/editor-ui/src/components/CollectionCard.vue
@@ -1,5 +1,5 @@
 <template>
-	<Card :loading="loading" :title="collection.name" @click="onClick">
+	<Card :loading="loading" :title="collection.name">
 		<template #footer>
 			<n8n-text size="small" color="text-light">
 				{{ collection.workflows.length }}
@@ -31,11 +31,6 @@ export default defineComponent({
 		Card,
 		NodeList,
 	},
-	methods: {
-		onClick(e: MouseEvent) {
-			this.$emit('click', e);
-		},
-	},
 });
 </script>
 
diff --git a/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue b/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue
index 43f4bf5ad2..5f04d40398 100644
--- a/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue
+++ b/packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue
@@ -197,10 +197,8 @@ export default defineComponent({
 		},
 	},
 	setup() {
-		const loadingService = useLoadingService();
-
 		return {
-			loadingService,
+			...useLoadingService(),
 			...useTitleChange(),
 			...useToast(),
 			...useMessage(),
diff --git a/packages/editor-ui/src/components/NodeDetailsView.vue b/packages/editor-ui/src/components/NodeDetailsView.vue
index 0407bc8c58..f0aaf180c3 100644
--- a/packages/editor-ui/src/components/NodeDetailsView.vue
+++ b/packages/editor-ui/src/components/NodeDetailsView.vue
@@ -694,7 +694,7 @@ export default defineComponent({
 
 <style lang="scss">
 .ndv-wrapper {
-	overflow: hidden;
+	overflow: visible;
 }
 
 .data-display-wrapper {
@@ -711,7 +711,7 @@ export default defineComponent({
 		padding: 0 !important;
 		height: 100%;
 		min-height: 400px;
-		overflow: hidden;
+		overflow: visible;
 		border-radius: 8px;
 	}
 }
diff --git a/packages/editor-ui/src/components/NodeSettings.vue b/packages/editor-ui/src/components/NodeSettings.vue
index 5d61fb78e5..caaad8633f 100644
--- a/packages/editor-ui/src/components/NodeSettings.vue
+++ b/packages/editor-ui/src/components/NodeSettings.vue
@@ -291,10 +291,10 @@ export default defineComponent({
 			return this.ndvStore.outputPanelEditMode;
 		},
 		isCommunityNode(): boolean {
-			return isCommunityPackageName(this.node.type);
+			return isCommunityPackageName(this.node?.type);
 		},
 		isTriggerNode(): boolean {
-			return this.nodeTypesStore.isTriggerNode(this.node.type);
+			return this.nodeTypesStore.isTriggerNode(this.node?.type);
 		},
 		workflowOwnerName(): string {
 			return this.workflowsEEStore.getWorkflowOwnerName(`${this.workflowsStore.workflowId}`);
@@ -614,7 +614,7 @@ export default defineComponent({
 			}
 			// Save the node name before we commit the change because
 			// we need the old name to rename the node properly
-			const nodeNameBefore = parameterData.node || this.node.name;
+			const nodeNameBefore = parameterData.node || this.node?.name;
 			const node = this.workflowsStore.getNodeByName(nodeNameBefore);
 
 			if (node === null) {
@@ -935,8 +935,8 @@ export default defineComponent({
 		onMissingNodeLearnMoreLinkClick() {
 			this.$telemetry.track('user clicked cnr docs link', {
 				source: 'missing node modal source',
-				package_name: this.node.type.split('.')[0],
-				node_type: this.node.type,
+				package_name: this.node?.type.split('.')[0],
+				node_type: this.node?.type,
 			});
 		},
 		onStopExecution() {
diff --git a/packages/editor-ui/src/components/SaveButton.vue b/packages/editor-ui/src/components/SaveButton.vue
index 4d78e8844d..0a9d5f9327 100644
--- a/packages/editor-ui/src/components/SaveButton.vue
+++ b/packages/editor-ui/src/components/SaveButton.vue
@@ -8,7 +8,6 @@
 			:disabled="disabled"
 			:class="$style.button"
 			:type="type"
-			@click="$emit('click')"
 		/>
 	</span>
 </template>
diff --git a/packages/editor-ui/src/composables/useLoadingService.ts b/packages/editor-ui/src/composables/useLoadingService.ts
index 9b698e296b..a5a7c6bedf 100644
--- a/packages/editor-ui/src/composables/useLoadingService.ts
+++ b/packages/editor-ui/src/composables/useLoadingService.ts
@@ -38,6 +38,7 @@ export function useLoadingService() {
 	}
 
 	return {
+		loadingService,
 		startLoading,
 		setLoadingText,
 		stopLoading,
diff --git a/packages/editor-ui/src/mixins/workflowHelpers.ts b/packages/editor-ui/src/mixins/workflowHelpers.ts
index c5f1c2fd87..ecfa9b259f 100644
--- a/packages/editor-ui/src/mixins/workflowHelpers.ts
+++ b/packages/editor-ui/src/mixins/workflowHelpers.ts
@@ -748,6 +748,8 @@ export const workflowHelpers = defineComponent({
 
 				return true;
 			} catch (error) {
+				console.error(error);
+
 				this.uiStore.removeActiveAction('workflowSaving');
 
 				if (error.errorCode === 100) {